From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: zsh-workers@sunsite.dk (Zsh hackers list)
Subject: Re: PATCH: bad clash between process substitution and numeric glob
Date: Tue, 18 Nov 2008 20:23:06 +0000 [thread overview]
Message-ID: <20081118202306.1ad2dbe1@pws-pc> (raw)
In-Reply-To: <8149.1227030382@thecus>
On Tue, 18 Nov 2008 18:46:22 +0100
Oliver Kiddle <okiddle@yahoo.co.uk> wrote:
> Bart wrote:
> > Correct me if I'm wrong, but this is going to break zcompiled scripts
> > that were created with earlier versions of the shell.
> >
> > Not that you need to avoid that, but it might be worth explicitly
> > calling out if true, and also bump the ZSH_VERSION number so it's
> > detectable at run time.
>
> My understanding was that the "magic" numbers in parse.c are supposed to
> be changed if you break wordcode files. Seems the last person to change
> those was me back in 2001. See Sven's comment to parse.c version 1.30
> in CVS. I know I just followed what Sven had done so 03040506 became
> 04050607.
As there's a comparison after the magic numbers with the shell version,
I think that's only necessary if the header format changes (the first
FD_PRELEN words). Otherwise changing the version number is good enough.
--
Peter Stephenson <p.w.stephenson@ntlworld.com>
Web page now at http://homepage.ntlworld.com/p.w.stephenson/
prev parent reply other threads:[~2008-11-18 20:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-18 9:59 Peter Stephenson
2008-11-18 15:24 ` Bart Schaefer
2008-11-18 16:04 ` Peter Stephenson
2008-11-18 17:46 ` Oliver Kiddle
2008-11-18 20:23 ` Peter Stephenson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081118202306.1ad2dbe1@pws-pc \
--to=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).