From: Peter Stephenson <pws@csr.com>
To: zsh-workers@sunsite.dk
Subject: Re: Seg. Fault when calling "cd" with set "chpwd" hook from a widget
Date: Tue, 25 Nov 2008 18:36:28 +0000 [thread overview]
Message-ID: <20081125183628.5194962b@news01> (raw)
In-Reply-To: <20081125000535.GC30055@unknown>
On Tue, 25 Nov 2008 01:05:37 +0100
Jonas Kramer <jkramer@nex.scrapping.cc> wrote:
> Hi workers,
>
> I've experienced a seg. fault in zsh when doing the following:
>...
> This seems to happen in
> hist.c:1138, where hptr points to NULL at that point. I tried to fix it
> myself, but I can't find a clean solution as I can't find the source of
> the problem. Just checking for hptr being NULL in hend() would just fix
> the symptom, not the cause I guess.
Actually, I think that's the right fix: I recently moved the *hptr = '\0'
up to that point because in some cases chline gets accessed quite early,
but I didn't do the checks that are usually done before accessing it.
Index: Src/hist.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/hist.c,v
retrieving revision 1.85
diff -u -r1.85 hist.c
--- Src/hist.c 22 Sep 2008 08:47:01 -0000 1.85
+++ Src/hist.c 25 Nov 2008 18:34:28 -0000
@@ -1130,12 +1130,14 @@
&& (hist_ignore_all_dups = isset(HISTIGNOREALLDUPS)) != 0)
histremovedups();
- /*
- * Added the following in case the test "hptr < chline + 1"
- * is more than just paranoia.
- */
- DPUTS(hptr < chline, "History end pointer off start of line");
- *hptr = '\0';
+ if (hptr) {
+ /*
+ * Added the following in case the test "hptr < chline + 1"
+ * is more than just paranoia.
+ */
+ DPUTS(hptr < chline, "History end pointer off start of line");
+ *hptr = '\0';
+ }
addlinknode(hookargs, "zshaddhistory");
addlinknode(hookargs, chline);
callhookfunc("zshaddhistory", hookargs, 1, &hookret);
--
Peter Stephenson <pws@csr.com> Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070
next prev parent reply other threads:[~2008-11-25 18:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-25 0:05 Jonas Kramer
2008-11-25 18:36 ` Peter Stephenson [this message]
2008-11-25 18:40 ` Peter Stephenson
2008-11-30 4:31 ` Bart Schaefer
2008-11-30 10:59 ` Jonas Kramer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081125183628.5194962b@news01 \
--to=pws@csr.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).