From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7379 invoked from network); 30 Dec 2008 04:55:33 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 30 Dec 2008 04:55:33 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 21346 invoked from network); 30 Dec 2008 04:55:27 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 30 Dec 2008 04:55:27 -0000 Received: (qmail 4828 invoked by alias); 30 Dec 2008 04:55:22 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 26201 Received: (qmail 4811 invoked from network); 30 Dec 2008 04:55:22 -0000 Received: from bifrost.dotsrc.org (130.225.254.106) by sunsite.dk with SMTP; 30 Dec 2008 04:55:22 -0000 Received: from cork.scru.org (cork.scru.org [209.20.67.2]) by bifrost.dotsrc.org (Postfix) with ESMTPS id DDE3380308BE for ; Tue, 30 Dec 2008 05:55:16 +0100 (CET) Received: by cork.scru.org (Postfix, from userid 1000) id F3133104158; Tue, 30 Dec 2008 04:55:14 +0000 (UTC) Date: Tue, 30 Dec 2008 04:55:14 +0000 From: Clint Adams To: Matt Wozniski Cc: Richard Hartmann , 381842@bugs.debian.org, zsh-workers@sunsite.dk Subject: Re: Bug triage Message-ID: <20081230045514.GA27687@scru.org> Mail-Followup-To: Matt Wozniski , Richard Hartmann , 381842@bugs.debian.org, zsh-workers@sunsite.dk References: <2d460de70812291311s3fe60715of556b785037f3bb1@mail.gmail.com> <20081229233506.GM17090@prunille.vinc17.org> <17393e3e0812291540u366992a2l4ef42fee6341a0bf@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17393e3e0812291540u366992a2l4ef42fee6341a0bf@mail.gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-Virus-Scanned: ClamAV 0.92.1/8812/Tue Dec 30 01:49:14 2008 on bifrost X-Virus-Status: Clean On Mon, Dec 29, 2008 at 06:40:33PM -0500, Matt Wozniski wrote: > Seems that not defining the variable when the function that defined it > was interrupted would be best, if it's not too tough to implement. > Regarding an empty variable as invalid is still better than allowing > an empty variable, but depending on the code (which I haven't looked > at) it might be able to create a variable holding only part of a valid > cache. > > Just something to think about. I don't know. How about Index: Completion/Debian/Type/_deb_packages =================================================================== RCS file: /cvsroot/zsh/zsh/Completion/Debian/Type/_deb_packages,v retrieving revision 1.8 diff -u -r1.8 _deb_packages --- Completion/Debian/Type/_deb_packages 2 Nov 2008 14:12:29 -0000 1.8 +++ Completion/Debian/Type/_deb_packages 30 Dec 2008 04:54:18 -0000 @@ -6,9 +6,11 @@ if ( [[ ${+_deb_packages_cache_avail} -eq 0 ]] || _cache_invalid DEBS_avail ) && ! _retrieve_cache DEBS_avail; then - _deb_packages_cache_avail=( + if _deb_packages_cache_avail=( ${(f)"$(apt-cache --generate pkgnames 2>/dev/null)"} - ) + ); then + unset _deb_packages_cache_avail + fi _store_cache DEBS_avail _deb_packages_cache_avail fi