From: Peter Stephenson <pws@csr.com>
To: Zsh hackers list <zsh-workers@sunsite.dk>
Subject: Re: Getting the CVS revision of Zsh
Date: Thu, 15 Jan 2009 14:38:38 +0000 [thread overview]
Message-ID: <20090115143838.43bc3dbb@news01> (raw)
In-Reply-To: <20090114233659.GA29158@scru.org>
On Wed, 14 Jan 2009 23:36:59 +0000
Clint Adams <schizo@debian.org> wrote:
> On Wed, Jan 14, 2009 at 05:22:35PM +0000, Peter Stephenson wrote:
> > If someone is really bundling individual patches with zsh, so that it is
> > different from any CVS checkout, then I would urge them to alter
> > $ZSH_PATCHLEVEL to avoid exactly the sort of confusion you describe. I
> > can add a config option to fix a patchlevel if this is useful.
>
> Yes, we do this. I can just patch zsh.mdd to work around it though.
In that case Bart's concerns are entirely real and this at least gives us
some kind of hook for people to indicate something funny is going on.
Arguably this should go after the standard version string in $ZSH_VERSION,
but I don't want yet more grief with additional customization. I've spent
far too much time arguing about this already.
I'm fairly happy ZSH_PATCHLEVEL is enough at least for what I'd like it
do. It's easy to find out what it should be in a released version and so
check if you're in a released version if you really need to.
Index: INSTALL
===================================================================
RCS file: /cvsroot/zsh/zsh/INSTALL,v
retrieving revision 1.37
diff -u -r1.37 INSTALL
--- INSTALL 30 Oct 2008 12:09:18 -0000 1.37
+++ INSTALL 15 Jan 2009 14:31:56 -0000
@@ -271,6 +271,19 @@
CONFIGURATION OPTIONS
=====================
+Modified versions of zsh
+------------------------
+
+If you are making local modifications to zsh, you are strongly
+advised to configure with the option
+
+ --enable-local-patchlevel="<my-mod-string>"
+
+so that the variable $ZSH_PATCHLEVEL indicates this is not a standard
+version of the shell. The argument is arbitrary, but should indicate
+the entity that is customizing the shell, for example the OS vendor
+or distributor.
+
Multibyte Character Support
---------------------------
Index: configure.ac
===================================================================
RCS file: /cvsroot/zsh/zsh/configure.ac,v
retrieving revision 1.116
diff -u -r1.116 configure.ac
--- configure.ac 13 Jan 2009 17:10:22 -0000 1.116
+++ configure.ac 15 Jan 2009 14:31:56 -0000
@@ -304,6 +304,14 @@
AC_SUBST(scriptdir)dnl
AC_SUBST(sitescriptdir)dnl
+AH_TEMPLATE([CUSTOM_PATCHLEVEL],
+[Define to a custom value for the ZSH_PATCHLEVEL parameter])
+AC_ARG_ENABLE(custom-patchlevel,
+AC_HELP_STRING([--enable-custom-patchlevel], [set a custom ZSH_PATCHLEVEL value]),
+[if test x$enableval != x && test x$enableval != xno; then
+ AC_DEFINE_UNQUOTED([CUSTOM_PATCHLEVEL], ["$enableval"])
+fi])
+
dnl Do you want maildir support?
ifdef([maildir_support],[undefine([maildir_support])])dnl
AH_TEMPLATE([MAILDIR_SUPPORT],
Index: Src/params.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/params.c,v
retrieving revision 1.152
diff -u -r1.152 params.c
--- Src/params.c 9 Jan 2009 20:28:30 -0000 1.152
+++ Src/params.c 15 Jan 2009 14:31:57 -0000
@@ -31,7 +31,11 @@
#include "params.pro"
#include "version.h"
+#ifdef CUSTOM_PATCHLEVEL
+#define ZSH_PATCHLEVEL CUSTOM_PATCHLEVEL
+#else
#include "patchlevel.h"
+#endif
/* what level of localness we are at */
--
Peter Stephenson <pws@csr.com> Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070
next prev parent reply other threads:[~2009-01-15 14:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2d460de70901090301h6b309a7cm19c5ebfec989ff2c@mail.gmail.com>
[not found] ` <200901091121 .n09BLVvZ006382@news01.csr.com>
[not found] ` <200901091121.n09BLVvZ006382@news01.csr.com>
[not found] ` <2d460de70901090348t3ea9e25fi29a7165ee42ae5e5@mail.gmail.com>
[not found] ` <200901091158.n09BwPii006839@news01.csr.com>
[not found] ` <2d460de7090 1090441i7ef1795bs42ed98fe0f33c9ba@mail.gmail.com>
[not found] ` <200901091258.n09CwS7T007 471@news01.csr.com>
[not found] ` <2d460de70901090441i7ef1795bs42ed98fe0f33c9ba@mail.gmail.com>
[not found] ` <200901091258.n09CwS7T007471@news01.csr.com>
[not found] ` <2d460de70901090507i7c3179e4u1e2def459f214566@mail.gmail.com>
2009-01-09 20:13 ` Peter Stephenson
2009-01-09 22:33 ` Richard Hartmann
2009-01-10 21:43 ` Peter Stephenson
2009-01-13 5:25 ` Jun T.
2009-01-13 10:09 ` Peter Stephenson
2009-01-14 3:48 ` Jun T.
[not found] ` <2d460de70901140533icf13f94yc7f63f974b236f45@mail.gmail.com>
[not found] ` <090114085737.ZM18662@torch.brasslantern.com>
2009-01-14 17:22 ` Peter Stephenson
2009-01-14 23:36 ` Clint Adams
2009-01-15 14:38 ` Peter Stephenson [this message]
2009-01-14 18:54 ` Mikael Magnusson
2009-01-15 19:43 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090115143838.43bc3dbb@news01 \
--to=pws@csr.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).