From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9760 invoked from network); 15 Jan 2009 19:44:20 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 15 Jan 2009 19:44:20 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 52733 invoked from network); 15 Jan 2009 19:44:14 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 15 Jan 2009 19:44:14 -0000 Received: (qmail 14336 invoked by alias); 15 Jan 2009 19:44:09 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 26315 Received: (qmail 14318 invoked from network); 15 Jan 2009 19:44:08 -0000 Received: from bifrost.dotsrc.org (130.225.254.106) by sunsite.dk with SMTP; 15 Jan 2009 19:44:08 -0000 Received: from mtaout01-winn.ispmail.ntl.com (mtaout01-winn.ispmail.ntl.com [81.103.221.47]) by bifrost.dotsrc.org (Postfix) with ESMTP id CA4AD8028ACA for ; Thu, 15 Jan 2009 20:43:54 +0100 (CET) Received: from aamtaout01-winn.ispmail.ntl.com ([81.103.221.35]) by mtaout01-winn.ispmail.ntl.com (InterMail vM.7.08.04.00 201-2186-134-20080326) with ESMTP id <20090115194353.BLVK2989.mtaout01-winn.ispmail.ntl.com@aamtaout01-winn.ispmail.ntl.com> for ; Thu, 15 Jan 2009 19:43:53 +0000 Received: from pws-pc ([81.107.45.176]) by aamtaout01-winn.ispmail.ntl.com (InterMail vG.2.02.00.01 201-2161-120-102-20060912) with ESMTP id <20090115194353.CARZ19264.aamtaout01-winn.ispmail.ntl.com@pws-pc> for ; Thu, 15 Jan 2009 19:43:53 +0000 Date: Thu, 15 Jan 2009 19:43:48 +0000 From: Peter Stephenson To: Zsh Hackers' List Subject: Re: Getting the CVS revision of Zsh Message-ID: <20090115194348.55b8c86b@pws-pc> In-Reply-To: <237967ef0901141054y35a4fafdpade3134bc49f69aa@mail.gmail.com> References: <2d460de70901090301h6b309a7cm19c5ebfec989ff2c@mail.gmail.com> <2d460de70901140533icf13f94yc7f63f974b236f45@mail.gmail.com> <090114085737.ZM18662@torch.brasslantern.com> <237967ef0901141054y35a4fafdpade3134bc49f69aa@mail.gmail.com> X-Mailer: Claws Mail 3.6.1 (GTK+ 2.14.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Cloudmark-Analysis: v=1.0 c=1 a=2o9eVglb3IMA:10 a=NLZqzBF-AAAA:8 a=6jGyD_u-g23Ayn1WGlsA:9 a=dGg0dt5gHUhvM5NlzJsA:7 a=nmly9ZAVv2v9ytcjxyR09Sb8ydYA:4 a=LY0hPdMaydYA:10 X-Virus-Scanned: ClamAV 0.92.1/8869/Thu Jan 15 18:37:21 2009 on bifrost X-Virus-Status: Clean On Wed, 14 Jan 2009 19:54:02 +0100 Mikael Magnusson wrote: > FWIW, I use a git import which doesn't do any keyword expansion, so > the define is empty in my case, which obviously breaks the build. I > don't know if you want to a) not care b) add some #ifdef to set it to > "unknown" or such or c) add some shell code for git to set it. > > If b or c I can construct a patch. If keyword expansion is properly turned off it shouldn't remove the CVS one, although I don't know the details of how git works. The second option is probably the easiest; it's straightforward now sed outputs the entire line, so the definition is completely missing if not found. Index: Src/params.c =================================================================== RCS file: /cvsroot/zsh/zsh/Src/params.c,v retrieving revision 1.153 diff -u -r1.153 params.c --- Src/params.c 15 Jan 2009 14:49:51 -0000 1.153 +++ Src/params.c 15 Jan 2009 19:42:36 -0000 @@ -35,6 +35,11 @@ #define ZSH_PATCHLEVEL CUSTOM_PATCHLEVEL #else #include "patchlevel.h" + +/* If removed from the ChangeLog for some reason */ +#ifndef ZSH_PATCHLEVEL +#define ZSH_PATCHLEVEL "unknown" +#endif #endif /* what level of localness we are at */ -- Peter Stephenson Web page now at http://homepage.ntlworld.com/p.w.stephenson/