From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: zsh-workers@sunsite.dk
Subject: Re: PATCH: add zle-line-finish special widget
Date: Sat, 17 Jan 2009 17:48:08 +0000 [thread overview]
Message-ID: <20090117174808.11395fa8@pws-pc> (raw)
In-Reply-To: <m33afix0x0.fsf_-_@klanderman.net>
On Fri, 16 Jan 2009 18:54:03 -0500
Greg Klanderman <gak@klanderman.net> wrote:
> > it's possible that the zle-line-finish widget should not run when
> > errflag != 0.
>
> > I don't know all the ramifications of the values of various globals
> > at the end of zlecore(). PWS?
I suspect if you don't set errflag to 0 at that point (and it's
non-zero) it might not run anyway, but I haven't looked (I would have to
trace the code or test it, which you can do if you feel inclined).
I don't know if this is correct or not---it really depends what
zle-line-finish is designed to do. If it's a catch-all tidy up, it
probably *should* run and then you probably should set errflag to 0
after saving the surrounding value.
You might want to check if Bart's recent comments on zle-line-init are
relevant.
--
Peter Stephenson <p.w.stephenson@ntlworld.com>
Web page now at http://homepage.ntlworld.com/p.w.stephenson/
next prev parent reply other threads:[~2009-01-17 17:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <18789.30656.261463.382208@gargle.gargle.HOWL>
[not found] ` <20090110095231.GA61601@redoubt.spodhuis.org>
[not found] ` <m33afq97gg.fsf@klanderman.net>
[not found] ` <20090111025418.GA7272@redoubt.spodhuis.org>
[not found] ` <m3tz857mkm.fsf@klanderman.net>
[not found] ` <090111110748.ZM12349@torch.brasslantern.com>
[not found] ` <m3r63975pd.fsf@klanderman.net>
[not found] ` <m3ocyd70aj.fsf@klanderman.net>
[not found] ` <090111193317.ZM12655@torch.brasslantern.com>
2009-01-12 4:00 ` some way to inherit kill ring in su'd shell? Greg Klanderman
2009-01-12 5:33 ` Bart Schaefer
2009-01-12 19:33 ` Greg Klanderman
2009-01-12 23:55 ` Richard Hartmann
2009-01-16 23:54 ` PATCH: add zle-line-finish special widget Greg Klanderman
2009-01-17 17:48 ` Peter Stephenson [this message]
2009-01-17 18:08 ` Bart Schaefer
2009-01-23 0:50 ` Greg Klanderman
2009-01-23 9:37 ` Peter Stephenson
2009-01-28 4:38 ` Greg Klanderman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090117174808.11395fa8@pws-pc \
--to=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).