From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5765 invoked from network); 17 Jan 2009 17:48:43 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 17 Jan 2009 17:48:43 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 30344 invoked from network); 17 Jan 2009 17:48:36 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 17 Jan 2009 17:48:36 -0000 Received: (qmail 3271 invoked by alias); 17 Jan 2009 17:48:29 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 26343 Received: (qmail 3254 invoked from network); 17 Jan 2009 17:48:28 -0000 Received: from bifrost.dotsrc.org (130.225.254.106) by sunsite.dk with SMTP; 17 Jan 2009 17:48:28 -0000 Received: from mtaout01-winn.ispmail.ntl.com (mtaout01-winn.ispmail.ntl.com [81.103.221.47]) by bifrost.dotsrc.org (Postfix) with ESMTP id D3D8880271F0 for ; Sat, 17 Jan 2009 18:48:25 +0100 (CET) Received: from aamtaout01-winn.ispmail.ntl.com ([81.103.221.35]) by mtaout01-winn.ispmail.ntl.com (InterMail vM.7.08.04.00 201-2186-134-20080326) with ESMTP id <20090117174816.JNZM2989.mtaout01-winn.ispmail.ntl.com@aamtaout01-winn.ispmail.ntl.com> for ; Sat, 17 Jan 2009 17:48:16 +0000 Received: from pws-pc ([81.107.45.176]) by aamtaout01-winn.ispmail.ntl.com (InterMail vG.2.02.00.01 201-2161-120-102-20060912) with ESMTP id <20090117174813.DZVR19264.aamtaout01-winn.ispmail.ntl.com@pws-pc> for ; Sat, 17 Jan 2009 17:48:13 +0000 Date: Sat, 17 Jan 2009 17:48:08 +0000 From: Peter Stephenson To: zsh-workers@sunsite.dk Subject: Re: PATCH: add zle-line-finish special widget Message-ID: <20090117174808.11395fa8@pws-pc> In-Reply-To: References: <18789.30656.261463.382208@gargle.gargle.HOWL> <20090110095231.GA61601@redoubt.spodhuis.org> <20090111025418.GA7272@redoubt.spodhuis.org> <090111110748.ZM12349@torch.brasslantern.com> <090111193317.ZM12655@torch.brasslantern.com> X-Mailer: Claws Mail 3.6.1 (GTK+ 2.14.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Cloudmark-Analysis: v=1.0 c=1 a=leFnXNEK68cA:10 a=XOM4TC78V5UA:10 a=NLZqzBF-AAAA:8 a=54Bwvf38t5g-sVkZcQIA:9 a=0bGvim0_5AXK-Pe5g5kZ_VpatK0A:4 a=LY0hPdMaydYA:10 X-Virus-Scanned: ClamAV 0.92.1/8873/Sat Jan 17 04:33:31 2009 on bifrost X-Virus-Status: Clean On Fri, 16 Jan 2009 18:54:03 -0500 Greg Klanderman wrote: > > it's possible that the zle-line-finish widget should not run when > > errflag != 0. > > > I don't know all the ramifications of the values of various globals > > at the end of zlecore(). PWS? I suspect if you don't set errflag to 0 at that point (and it's non-zero) it might not run anyway, but I haven't looked (I would have to trace the code or test it, which you can do if you feel inclined). I don't know if this is correct or not---it really depends what zle-line-finish is designed to do. If it's a catch-all tidy up, it probably *should* run and then you probably should set errflag to 0 after saving the surrounding value. You might want to check if Bart's recent comments on zle-line-init are relevant. -- Peter Stephenson Web page now at http://homepage.ntlworld.com/p.w.stephenson/