zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <pws@csr.com>
To: zsh-workers@sunsite.dk
Subject: Re: changing bindings in isearch mode?
Date: Mon, 19 Jan 2009 09:44:53 +0000	[thread overview]
Message-ID: <20090119094453.4f66076b@news01> (raw)
In-Reply-To: <m3priln64m.fsf@klanderman.net>

On Sat, 17 Jan 2009 13:23:53 -0500
Greg Klanderman <gak@klanderman.net> wrote:
> 
> >>>>> Peter Stephenson <p.w.stephenson@ntlworld.com> writes:
> 
> > Absolutely, but it's a very tricky change to push the behaviour into
> > functions.  Translation:  it's not clear anyone knows how to do this and
> > it's very clear no one has the time to find out.
> 
> I don't think you need (or even want) to push the behavior into
> functions; the menu-select widget already uses the "menuselect"
> keymap.  It looks like it's just casing on the commands that are
> bound, not executing them necessarily, and this seems to also be how
> the isearch code is written, using tests of the form
> 
>         cmd == Th(z_****)
> 
> Just glancing over the code, it would appear not too hard to create a
> keymap for isearch, add an isearch-exit widget, and add a case for it
> in doisearch.  Does that seem like a reasonable solution?

Yes, it looks like you're right.

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070


  reply	other threads:[~2009-01-19  9:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-17  6:54 Greg Klanderman
2009-01-17 17:56 ` Peter Stephenson
2009-01-17 18:23   ` Greg Klanderman
2009-01-19  9:44     ` Peter Stephenson [this message]
2009-01-19 12:12       ` Peter Stephenson
2009-01-19 17:17         ` Bart Schaefer
2009-01-22  4:01           ` Greg Klanderman
2009-01-22  9:57             ` Bart Schaefer
2009-01-22 21:25               ` Greg Klanderman
2009-01-21 20:43         ` Greg Klanderman
2009-01-17 19:17 ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090119094453.4f66076b@news01 \
    --to=pws@csr.com \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).