From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25837 invoked from network); 19 Jan 2009 21:35:40 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 19 Jan 2009 21:35:40 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 94875 invoked from network); 19 Jan 2009 21:35:35 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 19 Jan 2009 21:35:35 -0000 Received: (qmail 9712 invoked by alias); 19 Jan 2009 21:35:31 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 26370 Received: (qmail 9699 invoked from network); 19 Jan 2009 21:35:30 -0000 Received: from bifrost.dotsrc.org (130.225.254.106) by sunsite.dk with SMTP; 19 Jan 2009 21:35:30 -0000 Received: from mx.spodhuis.org (redoubt.spodhuis.org [193.202.115.177]) by bifrost.dotsrc.org (Postfix) with ESMTPS id DE06F80271F0 for ; Mon, 19 Jan 2009 22:35:26 +0100 (CET) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=d200807; d=spodhuis.org; h=Received:Date:From:To:Cc:Subject:Message-ID:Mail-Followup-To:References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To; b=KoYXX+bS5KwQcBAnBI/lSqajO3Yvyp4wd/pufmNsi5ufNndf2WGfXDA9MVbvsdi4WXXT2mVgZDB0eMEEKPwtHKQvCdAmNosGDgfyVF4JOxN19u4LYMAij94xaH+8XS7qsNWo3TOkHCGsZATDeeOqGESQDhxh/YT9UtHA+1L6D/U=; Received: by smtp.spodhuis.org with local id 1LP1mI-000HpW-9H; Mon, 19 Jan 2009 21:35:26 +0000 Date: Mon, 19 Jan 2009 13:35:26 -0800 From: Phil Pennock To: Wayne Davison Cc: zsh-workers@sunsite.dk Subject: Re: [PATCH] don't call regfree() on uninitialized regex_t Message-ID: <20090119213526.GB68041@redoubt.spodhuis.org> Mail-Followup-To: Wayne Davison , zsh-workers@sunsite.dk References: <20090119082203.GA16606@blorf.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090119082203.GA16606@blorf.net> X-Virus-Scanned: ClamAV 0.92.1/8877/Mon Jan 19 11:18:35 2009 on bifrost X-Virus-Status: Clean On 2009-01-19 at 00:22 -0800, Wayne Davison wrote: > While I was fixing a few compiler warnings in zcond_regex_match(), I > noticed that regfree() could be called on an uninitialized regex_t if > the "id" value passed in to the function was invalid. Attached is one > possible fix. Thanks -- looks like I was too clever for my own good. -Phil