zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <pws@csr.com>
Cc: zsh-workers@sunsite.dk
Subject: Re: PATCH: Error parsing $(...)
Date: Mon, 2 Mar 2009 10:06:41 +0000	[thread overview]
Message-ID: <20090302100641.58879b39@news01> (raw)
In-Reply-To: <090227083334.ZM24342@torch.brasslantern.com>

On Fri, 27 Feb 2009 08:33:34 -0800
Bart Schaefer <schaefer@brasslantern.com> wrote:
> This doesn't work properly with respect to NO_INTERACTIVECOMMENTS:
> 
> schaefer<501> print $(echo XX
> echo this # is not a comment
> echo YY)
> XX this YY
> schaefer<502> allopt interactive
> interactive           on
> interactivecomments   off

That behaviour hasn't changed, it's always worked that way.  The bug was
only that stuff after the '#' wasn't properly ignored.

It's never been well defined whether the text of a "$(...)" was
"interactive" in the sense meant.  The bit that happens interactively is
reading from "$(" until ")" is hit, during which the lexical analsyer isn't
looking for comments because it know the "end of the current interactive
line" (again, in some not very well defined sense) is after the ")".  After
that the string is stored internally and evaluated later.  Anyway, it's
probably too late to do it the other way now, but if someone wants to write
a patch to clarify it they're welcome.

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070


      reply	other threads:[~2009-03-02 10:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-26  8:45 Tomáš Smetana
2009-02-26 22:57 ` Peter Stephenson
2009-02-27 10:19   ` Peter Stephenson
2009-02-27 16:33     ` Bart Schaefer
2009-03-02 10:06       ` Peter Stephenson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090302100641.58879b39@news01 \
    --to=pws@csr.com \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).