zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <pws@csr.com>
To: Lionel Flandrin <lionel@svkt.org>
Cc: zsh-workers@sunsite.dk
Subject: Re: zsh 4.3.9: Interrupted "tcsetattr" call problem, tiling-wm related
Date: Mon, 2 Mar 2009 10:23:50 +0000	[thread overview]
Message-ID: <20090302102350.4fb8f638@news01> (raw)
In-Reply-To: <20090227161933.GE4173@shame.elexo.fr.local>

On Fri, 27 Feb 2009 17:20:25 +0100
Lionel Flandrin <lionel@svkt.org> wrote:
> A couple of grep and dirty fprintf in the source code later, I think
> I've found the root of the problem at Src/utils.c line 1440:
> 
> 1440          tcsetattr(SHTTY, TCSADRAIN, &ti->tio);
> 1441      /* if (tcsetattr(SHTTY, TCSADRAIN, &ti->tio) == -1) */
> 
> (It's interresting that the bugfix is almost already there :).

... just after the line that says "Princeton's include files are screwed
up".  It's interesting we're relying on an ad-hoc fix for a problem
(although not related to this one) on a single system that probably
disappeared ten years ago.

> Indeed, the problem seems to be that I use a tiling WM (stumpwm) that
> If I change the call to:
> 
>   while (tcsetattr(SHTTY, TCSADRAIN, &ti->tio) == -1 && errno == EINTR);
> 
> It fixes the problem.

That looks fine, I've committed it.  Thanks.

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070


  reply	other threads:[~2009-03-02 10:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-27 16:20 Lionel Flandrin
2009-03-02 10:23 ` Peter Stephenson [this message]
2009-03-02 16:01   ` Bart Schaefer
2009-03-02 16:15     ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090302102350.4fb8f638@news01 \
    --to=pws@csr.com \
    --cc=lionel@svkt.org \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).