From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2117 invoked from network); 8 Mar 2009 21:52:18 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,URIBL_SBL autolearn=no version=3.2.5 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 8 Mar 2009 21:52:18 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 58852 invoked from network); 8 Mar 2009 21:52:14 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 8 Mar 2009 21:52:14 -0000 Received: (qmail 13328 invoked by alias); 8 Mar 2009 21:52:09 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 26699 Received: (qmail 13316 invoked from network); 8 Mar 2009 21:52:09 -0000 Received: from bifrost.dotsrc.org (130.225.254.106) by sunsite.dk with SMTP; 8 Mar 2009 21:52:09 -0000 Received: from mtaout01-winn.ispmail.ntl.com (mtaout01-winn.ispmail.ntl.com [81.103.221.47]) by bifrost.dotsrc.org (Postfix) with ESMTP id 8D31080307F8 for ; Sun, 8 Mar 2009 22:52:05 +0100 (CET) Received: from aamtaout01-winn.ispmail.ntl.com ([81.103.221.35]) by mtaout01-winn.ispmail.ntl.com (InterMail vM.7.08.04.00 201-2186-134-20080326) with ESMTP id <20090308215204.KTLQ2989.mtaout01-winn.ispmail.ntl.com@aamtaout01-winn.ispmail.ntl.com> for ; Sun, 8 Mar 2009 21:52:04 +0000 Received: from pws-pc.ntlworld.com ([81.107.42.185]) by aamtaout01-winn.ispmail.ntl.com (InterMail vG.2.02.00.01 201-2161-120-102-20060912) with ESMTP id <20090308215204.GIMQ13254.aamtaout01-winn.ispmail.ntl.com@pws-pc.ntlworld.com> for ; Sun, 8 Mar 2009 21:52:04 +0000 Received: from pws-pc (pws-pc [127.0.0.1]) by pws-pc.ntlworld.com (8.14.3/8.14.2) with ESMTP id n28Lpx1H029934 for ; Sun, 8 Mar 2009 21:51:59 GMT Message-Id: <200903082151.n28Lpx1H029934@pws-pc.ntlworld.com> From: Peter Stephenson To: zsh-workers@sunsite.dk Subject: Re: Modules/attr.c compile error on Mac OS X In-Reply-To: Message from Bart Schaefer of "Sun, 08 Mar 2009 14:33:46 MST." <090308143346.ZM22657@torch.brasslantern.com> Date: Sun, 08 Mar 2009 21:51:59 +0000 X-Cloudmark-Analysis: v=1.0 c=1 a=I1ULntJ0f4UA:10 a=TbTACPgREAoA:10 a=NLZqzBF-AAAA:8 a=dnbszHOskDJScCeeI3EA:9 a=OGmjJBrbhhpcyxYjzg0A:7 a=m5B-5XcgdpEh8YqOYbKoMXGLfEUA:4 a=fUzIcyR-ki4A:10 a=_dQi-Dcv4p4A:10 X-Virus-Scanned: ClamAV 0.92.1/9080/Fri Mar 6 20:13:38 2009 on bifrost X-Virus-Status: Clean Bart Schaefer wrote: > However, it didn't build the attr module. Still didn't build it after > a "make clee an". Missing dependency? Trying again from "make distclean": > OK, compiled the attr module that time. I think that's because config.modules.sh doesn't get rerun automatically. I've come across the same thing. config.modules should probably depend on it somewhere. I wonder if the following fixes it or simply introduces some dependency loop... It's odd that *nothing* currently depends on config.modules, but maybe I just screwed up. > I tried this: >... > Is there more that should be tested? Looks pretty good to me; suggests that with the extra arguments it's not fundamentally broken. We could probably do with a Test module that only runs if zsh/attr is loadable and the file system supports extended attributes (i.e. if it doesn't load it should report as "couldn't test" rather than "test failed"). Index: Makefile.in =================================================================== RCS file: /cvsroot/zsh/zsh/Makefile.in,v retrieving revision 1.19 diff -u -r1.19 Makefile.in --- Makefile.in 1 Feb 2008 11:31:36 -0000 1.19 +++ Makefile.in 8 Mar 2009 21:45:59 -0000 @@ -41,7 +41,7 @@ # ========== DEPENDENCIES FOR BUILDING ========== # default target -all: config.h +all: config.h config.modules @for subdir in Src Doc; do \ (cd $$subdir && $(MAKE) $(MAKEDEFS) $@) || exit 1; \ done @@ -142,8 +142,9 @@ stamp-h: $(sdir)/config.h.in config.status cd $(dir_top) && $(SHELL) ./config.status config.h $@ -config.modules: $(sdir)/config.h.in config.status - cd $(dir_top) && $(SHELL) ./config.status $@ +config.modules: $(sdir)/config.h.in config.status config.modules.sh + cd $(dir_top) && $(SHELL) ./config.status $@ && \ + $(SHELL) ./config.modules.sh $(sdir)/config.h.in: $(sdir)/stamp-h.in $(sdir)/stamp-h.in: $(sdir)/configure.ac \ -- Peter Stephenson Web page now at http://homepage.ntlworld.com/p.w.stephenson/