From: Peter Stephenson <pws@csr.com>
To: zsh-workers <zsh-workers@sunsite.dk>
Subject: Re: cd -s symlink hangs (sometimes?)
Date: Mon, 23 Mar 2009 12:27:14 +0000 [thread overview]
Message-ID: <20090323122714.3373526a@news01> (raw)
In-Reply-To: <237967ef0903230446u6810c06cs511fddcc21fd2a8a@mail.gmail.com>
On Mon, 23 Mar 2009 12:46:10 +0100
Mikael Magnusson <mikachu@gmail.com> wrote:
> 2009/3/23 Peter Stephenson <pws@csr.com>:
> Trying the patch now and it does stop the leak... but you didn't think
> this adventure was over yet, did you?
No, I definitely want to fix the diagnostics and at the least the internal
setting of pwd when a cd fails, but I'm not sure what a neat way is.
> zsh -f
> % chmod -x .
> % cd -s /nonexisting
> cd: no such file or directory: /nonexisting
> % ls
> ls: write error: Bad file descriptor
That was finger trouble: parentheses in the wrong place.
Index: Src/utils.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/utils.c,v
retrieving revision 1.217
diff -u -r1.217 utils.c
--- Src/utils.c 23 Mar 2009 10:58:57 -0000 1.217
+++ Src/utils.c 23 Mar 2009 12:21:25 -0000
@@ -5423,7 +5423,7 @@
#ifdef HAVE_FCHDIR
if (d->dirfd < 0) {
close_dir = 1;
- if ((d->dirfd = open(".", O_RDONLY | O_NOCTTY) < 0) &&
+ if ((d->dirfd = open(".", O_RDONLY | O_NOCTTY)) < 0 &&
zgetdir(d) && *d->dirname != '/')
d->dirfd = open("..", O_RDONLY | O_NOCTTY);
}
--
Peter Stephenson <pws@csr.com> Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070
next prev parent reply other threads:[~2009-03-23 12:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-20 21:12 Mikael Magnusson
2009-03-20 22:48 ` Peter Stephenson
2009-03-20 23:15 ` Mikael Magnusson
2009-03-22 12:54 ` Peter Stephenson
2009-03-22 23:05 ` Mikael Magnusson
2009-03-23 10:49 ` Peter Stephenson
2009-03-23 11:46 ` Mikael Magnusson
2009-03-23 12:27 ` Peter Stephenson [this message]
2009-03-24 12:46 ` Peter Stephenson
2009-03-24 15:15 ` Bart Schaefer
2009-03-24 16:02 ` Peter Stephenson
2009-04-06 11:07 ` Mikael Magnusson
2009-04-06 11:13 ` Peter Stephenson
2009-03-23 15:18 ` Bart Schaefer
2009-03-23 15:39 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090323122714.3373526a@news01 \
--to=pws@csr.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).