Re: PATCH: Add CORRECT_NOCOMPSYS option

[Peter Stephenson <pws@csr.com>]

On Sun, 05 Apr 2009 15:11:15 -0700
Bart Schaefer <schaefer@brasslantern.com> wrote:
> On Apr 5,  7:13pm, Peter Stephenson wrote:
> }
> } Right, here's a more general solution.  Shout if I've missed something.
> 
> Looks reasonable to me.  Should it be made clearer that this does not
> apply to the CORRECT_ALL option?

I added the sentence

  The pattern does not apply the correction
  of file names, as applied by the tt(CORRECT_ALL) option (so with the
  example just given files beginning with `tt(_)' in the current
  directory would still be completed).

> I was just looking at adding something to _setup to copy the value of
> CORRECT_IGNORE into the ignored-patterns style, but that suffers from
> the same bootstrapping issues as MENUSELECT and ZLS_COLORS.  So maybe
> it would just be better to document it somewhere.
> 
> Or perhaps it would be good enough simply to set it if it is not set:
> 
> if ! zstyle -m ':completion:*:-command-:*' ignored-patterns '*'
> then
>   zstyle ':completion:*:-command-:*' ignored-patterns '_*'
> fi

Or maybe use $CORRECT_IGNORE here if set and maybe allow ignored-patterns
to be set in such a way that it won't do that.

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070