From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25909 invoked from network); 6 Apr 2009 09:09:50 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 6 Apr 2009 09:09:50 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 39142 invoked from network); 6 Apr 2009 09:09:45 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 6 Apr 2009 09:09:45 -0000 Received: (qmail 8073 invoked by alias); 6 Apr 2009 09:09:40 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 26811 Received: (qmail 8057 invoked from network); 6 Apr 2009 09:09:39 -0000 Received: from bifrost.dotsrc.org (130.225.254.106) by sunsite.dk with SMTP; 6 Apr 2009 09:09:39 -0000 Received: from cluster-d.mailcontrol.com (cluster-d.mailcontrol.com [85.115.60.190]) by bifrost.dotsrc.org (Postfix) with ESMTPS id D6F8382D4B6A for ; Mon, 6 Apr 2009 11:09:36 +0200 (CEST) Received: from cameurexb01.EUROPE.ROOT.PRI ([193.128.72.68]) by rly41d.srv.mailcontrol.com (MailControl) with ESMTP id n3699KKr019844 for ; Mon, 6 Apr 2009 10:09:35 +0100 Received: from news01 ([10.99.50.25]) by cameurexb01.EUROPE.ROOT.PRI with Microsoft SMTPSVC(6.0.3790.3959); Mon, 6 Apr 2009 10:09:29 +0100 Date: Mon, 6 Apr 2009 10:09:29 +0100 From: Peter Stephenson To: zsh-workers@sunsite.dk Subject: Re: PATCH: Add CORRECT_NOCOMPSYS option Message-ID: <20090406100929.505617e2@news01> In-Reply-To: <090405151115.ZM13159@torch.brasslantern.com> References: <1238890030-4683-1-git-send-email-ft@bewatermyfriend.org> <090404193718.ZM19801@torch.brasslantern.com> <20090405191304.1908fca8@pws-pc> <090405151115.ZM13159@torch.brasslantern.com> Organization: CSR X-Mailer: Claws Mail 3.5.0 (GTK+ 2.12.8; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 06 Apr 2009 09:09:29.0004 (UTC) FILETIME=[63F446C0:01C9B697] X-Scanned-By: MailControl A_08_51_00 (www.mailcontrol.com) on 10.68.0.151 X-Virus-Scanned: ClamAV 0.92.1/9206/Sun Apr 5 20:23:11 2009 on bifrost X-Virus-Status: Clean On Sun, 05 Apr 2009 15:11:15 -0700 Bart Schaefer wrote: > On Apr 5, 7:13pm, Peter Stephenson wrote: > } > } Right, here's a more general solution. Shout if I've missed something. > > Looks reasonable to me. Should it be made clearer that this does not > apply to the CORRECT_ALL option? I added the sentence The pattern does not apply the correction of file names, as applied by the tt(CORRECT_ALL) option (so with the example just given files beginning with `tt(_)' in the current directory would still be completed). > I was just looking at adding something to _setup to copy the value of > CORRECT_IGNORE into the ignored-patterns style, but that suffers from > the same bootstrapping issues as MENUSELECT and ZLS_COLORS. So maybe > it would just be better to document it somewhere. > > Or perhaps it would be good enough simply to set it if it is not set: > > if ! zstyle -m ':completion:*:-command-:*' ignored-patterns '*' > then > zstyle ':completion:*:-command-:*' ignored-patterns '_*' > fi Or maybe use $CORRECT_IGNORE here if set and maybe allow ignored-patterns to be set in such a way that it won't do that. -- Peter Stephenson Software Engineer CSR PLC, Churchill House, Cambridge Business Park, Cowley Road Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070