Re: zsh 4.3.9-dev-2, two test failures on NetBSD

[Peter Stephenson <pws@csr.com>]

On Mon, 20 Apr 2009 04:00:18 +0000
Paul Ackersviller <pda@sdf.lonestar.org> wrote:
> ./A01grammar.ztst: starting.
> *** /tmp/zsh.ztst.err.2701	Mon Apr 20 01:48:54 2009
> --- /tmp/zsh.ztst.terr.2701	Mon Apr 20 01:48:54 2009
> ***************
> *** 0 ****
> --- 1 ----
> + stty: TIOCGETD: Inappropriate ioctl for device
> Test ./A01grammar.ztst failed: error output differs from expected as shown above for:
>   (exec -l /bin/sh -c 'echo $0')
> Was testing: `exec' with -l option
> ./A01grammar.ztst: test failed.

We don't use TIOCGETD (get terminal line discipline) directly, so either
this is well buried or it's coming from /bin/sh.

> ./V01zmodload.ztst: starting.
> *** /tmp/zsh.ztst.err.15666	Mon Apr 20 01:50:13 2009
> --- /tmp/zsh.ztst.terr.15666	Mon Apr 20 01:50:13 2009
> ***************
> *** 0 ****
> --- 1,2 ----
> + (eval):3: module `zsh/terminfo' has no such feature: `b:echoti': autoload cancelled
> + (eval):3: module `zsh/terminfo' has no such feature: `p:terminfo': autoload cancelled
> Test ./V01zmodload.ztst failed: error output differs from expected as shown above for:
>  for m in $mods
>  do
>    zmodload -i $m || mods[(r)$m]=()
>  done
> Was testing: Test loading of all compiled modules
> ./V01zmodload.ztst: test failed.

Somehow zsh/terminfo is getting compiled and linked in, implying the tests
in Src/Modules/terminfo.c are succeeding (link is "either" or "static"):

link='if test "x$ac_cv_func_tigetflag" = xyes -a "x$ac_cv_header_curses_h" = xyes ||
      test x$ac_cv_header_ncurses_h = xyes || test x$ac_cv_header_ncurses_ncurses_h = xyes ||
      test x$ac_cv_header_ncursesw_ncurses_h = xyes; then
          if test "x$zsh_cv_shared_tigetstr" = xyes; then
	      echo either
	  else
	      echo static
	  fi
      else
          echo no;
      fi
'

even though USE_TERMINFO_MODULE isn't being defined, i.e.

#if defined(HAVE_TIGETFLAG) && defined(ZSH_HAVE_CURSES_H)
# define USE_TERMINFO_MODULE 1
#else
# undef USE_TERMINFO_MODULE
#endif

HAVE_TIGETFLAG or ZSH_HAVE_CURSES_H are not defined.

We should really test zsh_cv_path_curses_header in terminfo.mdd, though I
don't know if this is the problem.

Index: Src/Modules/terminfo.mdd
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Modules/terminfo.mdd,v
retrieving revision 1.13
diff -u -r1.13 terminfo.mdd
--- Src/Modules/terminfo.mdd	5 Dec 2007 15:21:23 -0000	1.13
+++ Src/Modules/terminfo.mdd	20 Apr 2009 16:44:37 -0000
@@ -1,8 +1,6 @@
 name=zsh/terminfo
 
-link='if test "x$ac_cv_func_tigetflag" = xyes -a "x$ac_cv_header_curses_h" = xyes ||
-      test x$ac_cv_header_ncurses_h = xyes || test x$ac_cv_header_ncurses_ncurses_h = xyes ||
-      test x$ac_cv_header_ncursesw_ncurses_h = xyes; then
+link='if test "x$ac_cv_func_tigetflag" = xyes -a x$zsh_cv_path_curses_header != xnone; then
           if test "x$zsh_cv_shared_tigetstr" = xyes; then
 	      echo either
 	  else


-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070