From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11272 invoked from network); 21 Apr 2009 16:01:57 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 21 Apr 2009 16:01:57 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 22282 invoked from network); 21 Apr 2009 16:01:52 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 21 Apr 2009 16:01:52 -0000 Received: (qmail 3827 invoked by alias); 21 Apr 2009 16:01:47 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 26863 Received: (qmail 3812 invoked from network); 21 Apr 2009 16:01:47 -0000 Received: from bifrost.dotsrc.org (130.225.254.106) by sunsite.dk with SMTP; 21 Apr 2009 16:01:47 -0000 Received: from cluster-g.mailcontrol.com (cluster-g.mailcontrol.com [208.87.233.190]) by bifrost.dotsrc.org (Postfix) with ESMTPS id 961228028C72 for ; Tue, 21 Apr 2009 18:00:35 +0200 (CEST) Received: from rly27g.srv.mailcontrol.com (localhost.localdomain [127.0.0.1]) by rly27g.srv.mailcontrol.com (MailControl) with ESMTP id n3LG1TU0026037 for ; Tue, 21 Apr 2009 17:01:29 +0100 Received: from submission.mailcontrol.com (submission.mailcontrol.com [86.111.216.190]) by rly27g.srv.mailcontrol.com (MailControl) id n3LG1A0x023793 for zsh-workers@sunsite.dk; Tue, 21 Apr 2009 17:01:10 +0100 Received: from cameurexb01.EUROPE.ROOT.PRI ([193.128.72.68]) by rly27g-eth0.srv.mailcontrol.com (envelope-sender Peter.Stephenson@csr.com) (MIMEDefang) with ESMTP id n3LG16vW023352; Tue, 21 Apr 2009 17:01:10 +0100 (BST) Received: from news01.csr.com ([10.99.50.25]) by cameurexb01.EUROPE.ROOT.PRI with Microsoft SMTPSVC(6.0.3790.3959); Tue, 21 Apr 2009 17:01:09 +0100 Received: from news01.csr.com (localhost.localdomain [127.0.0.1]) by news01.csr.com (8.14.2/8.13.4) with ESMTP id n3LG18aU021840; Tue, 21 Apr 2009 17:01:08 +0100 Received: from csr.com (pws@localhost) by news01.csr.com (8.14.2/8.14.2/Submit) with ESMTP id n3LG17jU021836; Tue, 21 Apr 2009 17:01:08 +0100 Message-Id: <200904211601.n3LG17jU021836@news01.csr.com> X-Authentication-Warning: news01.csr.com: pws owned process doing -bs To: gak@klanderman.net cc: zsh-workers@sunsite.dk Subject: Re: PATCH: _read_comp widget broken by 'setopt nounset' In-reply-to: References: <18831.51704.292282.667241@gargle.gargle.HOWL> Comments: In-reply-to Greg Klanderman message dated "Tue, 21 Apr 2009 11:49:11 -0400." Date: Tue, 21 Apr 2009 17:01:07 +0100 From: Peter Stephenson X-OriginalArrivalTime: 21 Apr 2009 16:01:09.0043 (UTC) FILETIME=[62856030:01C9C29A] X-Scanned-By: MailControl A_08_51_00 (www.mailcontrol.com) on 10.71.1.137 X-Virus-Scanned: ClamAV 0.92.1/9268/Tue Apr 21 17:10:12 2009 on bifrost X-Virus-Status: Clean Greg Klanderman wrote: > > Hi, I submitted this back in February, but it has not been applied or > commented on. Could someone take a look please? It's certainly harmless; we should also get around warncreateglobal warnings, too. Index: Completion/Base/Widget/_read_comp =================================================================== RCS file: /cvsroot/zsh/zsh/Completion/Base/Widget/_read_comp,v retrieving revision 1.1 diff -u -r1.1 _read_comp --- Completion/Base/Widget/_read_comp 2 Apr 2001 11:17:07 -0000 1.1 +++ Completion/Base/Widget/_read_comp 21 Apr 2009 16:00:44 -0000 @@ -23,9 +23,10 @@ # _read_comp Last completion string read from user # emulate -L zsh -setopt localoptions extendedglob nobadpattern # xtrace promptsubst +setopt localoptions extendedglob nobadpattern unset # xtrace promptsubst # local PS4='%N:%i:$((#key))> ' +typeset -g _read_comp if [[ ${+NUMERIC} = 0 && -n $_read_comp ]]; then if [[ $_read_comp = _* ]]; then eval $_read_comp -- Peter Stephenson Software Engineer CSR PLC, Churchill House, Cambridge Business Park, Cowley Road Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070