zsh-workers
 help / color / mirror / code / Atom feed
From: martin f krafft <madduck@debian.org>
To: 527301@bugs.debian.org, zsh-workers@sunsite.dk
Subject: Re: Bug#527301: _xmms2 jump/_values: suboptimal presentation/sorting
Date: Wed, 6 May 2009 21:36:09 +0200	[thread overview]
Message-ID: <20090506193609.GA3569@piper.oerlikon.madduck.net> (raw)
In-Reply-To: <20090506172631.GA2668@scru.org>

[-- Attachment #1: Type: text/plain, Size: 2095 bytes --]

also sprach Clint Adams <schizo@debian.org> [2009.05.06.1926 +0200]:
> zstyle :completion::complete:xmms2:\*:values list-grouped false
> zstyle :completion::complete:xmms2:\*:values sort false

Ooooh!

Which documentation did I not read? I tried
http://zsh.dotsrc.org/Doc/Release/zsh_19.html#SEC124 and the source
code, but I couldn't deduce this gem.

> I have no opinion on how the default behavior should be handled.

I'd say for playlists, grouping makes no sense, and since the
playlist is already passed sorted, sorting should be disabled,
especially since it doesn't do numeric sorting anyway.

My vote's for making your suggestion quoted above default.

On a side note: why is the playlist sorted in reverse order?

  18    -- Deep Purple - Smoke on the Water
  17    -- Deep Purple - Speed King
  16    -- Deep Purple - Anya
  15    -- Deep Purple - Child in Time
  14    -- Deep Purple - Anyone's Daugher
  13    -- Deep Purple - Perfect Strangers
  12    -- Deep Purple - A Twist in the Tail
  11    -- Deep Purple - Black Night
  10    -- Deep Purple - Highway Star
  9     -- Deep Purple - Lucille
  8     -- Deep Purple - Speed King
  7     -- Deep Purple - Black Night
  6     -- Deep Purple - Space Truckin'
  5     -- Deep Purple - Lazy
  4     -- Deep Purple - Strange Kind of Woman
  3     -- Deep Purple - The Mule
  2     -- Deep Purple - Smoke on the Water
  1     -- Deep Purple - Child in Time

I'd suggest

--- /tmp/_xmms2 2009-05-06 21:32:06.000000000 +0200
+++ /usr/share/zsh-beta/functions/Completion/Unix/_xmms2        2009-05-06 21:32:23.000000000 +0200
@@ -66,7 +66,7 @@
   fi
      done
      
-     _values -s ' ' 'playlist items' ${(On)playlistitems}
+     _values -s ' ' 'playlist items' ${(on)playlistitems}
 
 }

In addition.

-- 
 .''`.   martin f. krafft <madduck@d.o>      Related projects:
: :'  :  proud Debian developer               http://debiansystem.info
`. `'`   http://people.debian.org/~madduck    http://vcs-pkg.org
  `-  Debian - when you have better things to do than fixing systems

[-- Attachment #2: Digital signature (see http://martin-krafft.net/gpg/) --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

      reply	other threads:[~2009-05-06 19:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20090506162216.GA24031@piper.oerlikon.madduck.net>
2009-05-06 17:26 ` Clint Adams
2009-05-06 19:36   ` martin f krafft [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090506193609.GA3569@piper.oerlikon.madduck.net \
    --to=madduck@debian.org \
    --cc=527301@bugs.debian.org \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).