From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11208 invoked from network); 22 May 2009 16:17:58 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 Received: from new-brage.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.254.104) by ns1.primenet.com.au with SMTP; 22 May 2009 16:17:58 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 86570 invoked from network); 22 May 2009 16:17:51 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 22 May 2009 16:17:51 -0000 Received: (qmail 6146 invoked by alias); 22 May 2009 16:17:46 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 26981 Received: (qmail 6131 invoked from network); 22 May 2009 16:17:45 -0000 Received: from bifrost.dotsrc.org (130.225.254.106) by sunsite.dk with SMTP; 22 May 2009 16:17:45 -0000 Received: from smtprelay02.ispgateway.de (smtprelay02.ispgateway.de [80.67.18.14]) by bifrost.dotsrc.org (Postfix) with ESMTP id DCEBF801E289 for ; Fri, 22 May 2009 18:17:33 +0200 (CEST) Received: from [89.245.18.208] (helo=fsst.voodoo.lan) by smtprelay02.ispgateway.de with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.68) (envelope-from ) id 1M7XR7-0000aC-2V for zsh-workers@sunsite.dk; Fri, 22 May 2009 18:17:33 +0200 Received: from hawk by fsst.voodoo.lan with local (Exim 4.69) (envelope-from ) id 1M7XQx-0001sS-HO for zsh-workers@sunsite.dk; Fri, 22 May 2009 18:17:23 +0200 Date: Fri, 22 May 2009 18:17:23 +0200 From: Frank Terbeck To: zsh-workers@sunsite.dk Subject: Re: PATCH: add support for stgit in VCS_Info Message-ID: <20090522161723.GQ19860@fsst.voodoo.lan> Mail-Followup-To: zsh-workers@sunsite.dk References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-Df-Sender: 430444 X-Virus-Scanned: ClamAV 0.94.2/9382/Fri May 22 16:58:39 2009 on bifrost X-Virus-Status: Clean Julien Langer : > This patch adds some support for stgit to VCS_Info. It displays the > currently active patch and the number of unapplied patches. > The additional info is configured via a new "stgitformat" style and is put > into the "misc" part of the prompt. I don't know if this is the best idea, > what do you (Frank?) think? One thing, the rest of VCS_INFO_get_data_git() uses four spaces for indenting and the patch mixes tabs into that. Also when introducing a new style, a documentation update would be nice. :) Apart from that, technically the patch itself looks fine, IMO. However, I don't use stgit myself, so I can't give it a test drive. Regards, Frank -- In protocol design, perfection has been reached not when there is nothing left to add, but when there is nothing left to take away. -- RFC 1925