From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: Zsh list <zsh-workers@sunsite.dk>
Subject: Re: bug in ztrftime(): '%e' and '%f' specifiers swapped
Date: Fri, 26 Jun 2009 22:23:52 +0100 [thread overview]
Message-ID: <200906262123.n5QLNqJU008820@pws-pc.ntlworld.com> (raw)
In-Reply-To: Message from Greg Klanderman <gak@klanderman.net> of "Fri, 26 Jun 2009 16:40:25 EDT." <19013.12857.274684.466725@gargle.gargle.HOWL>
Greg Klanderman wrote:
> You have inadvertently swapped the meanings of the '%e' and '%f' format
> specifiers.
Thanks for tracking this down.
> However, I find this equivalent patch to be more readable:
Interesting how subjective this is, I find it significantly less so
(though they're certainly equivalent so this is all rather minor and if
you hadn't sent two patches I'd never even have thought about it):
- there is no immediate visual cue that the formats do different things
- the test for the format letter is repeated without it being obvious it
is the same test
- it's made even less obvious because the second test has to advance
back down the format string since the key letter isn't saved in a
variable [we do this sort of thing all the time elsewhere, though]
- the fact that 'f' sets the "strip" feature unconditionally is obscured
- I'm not that keen on "||" and "&&" in assignments anyway [again, the
shell is full of stuff I'm not that keen on]
so I've committed the first one.
> Btw, are the zsh extension format specifiers documented?
See the description of the %D format in the description of prompt
escapes, which is where these first occurred; feel free to add some more
cross references, I see there isn't one in the zsh/datetime description,
for example.
--
Peter Stephenson <p.w.stephenson@ntlworld.com>
Web page now at http://homepage.ntlworld.com/p.w.stephenson/
next prev parent reply other threads:[~2009-06-26 21:24 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <gak@klanderman.net>
2009-06-26 20:40 ` Greg Klanderman
2009-06-26 21:23 ` Peter Stephenson [this message]
2009-06-26 21:57 ` Greg Klanderman
2010-02-05 17:01 have '&' automatically disown? Greg Klanderman
2010-02-05 17:33 ` Peter Stephenson
2010-02-05 17:36 ` Peter Stephenson
2010-02-06 3:26 ` Greg Klanderman
2010-02-07 18:20 ` Peter Stephenson
2010-02-07 21:06 ` Greg Klanderman
2010-02-07 21:34 ` Peter Stephenson
2010-02-07 22:36 ` Bart Schaefer
2010-09-02 14:57 ` Greg Klanderman
2010-09-05 19:11 ` Bart Schaefer
2010-09-06 1:50 ` Greg Klanderman
2010-02-07 21:59 ` Mikael Magnusson
-- strict thread matches above, loose matches on Subject: below --
2009-05-17 4:55 PATCH: make PROMPT_SP end-of-line marker configurable Greg Klanderman
2009-05-17 17:27 ` Peter Stephenson
2009-05-17 18:04 ` Greg Klanderman
2009-05-17 19:23 ` Peter Stephenson
2009-05-18 1:00 ` Greg Klanderman
2009-05-18 18:27 ` Greg Klanderman
2009-01-13 7:32 treatment of empty strings - why is this not a bug? Greg Klanderman
2009-01-13 19:24 ` Peter Stephenson
2009-01-13 22:08 ` Peter Stephenson
2009-01-15 20:11 ` Greg Klanderman
2009-01-15 20:29 ` Peter Stephenson
2009-01-16 10:02 ` Peter Stephenson
2009-01-15 20:28 ` Greg Klanderman
2009-01-15 20:34 ` Peter Stephenson
2009-01-16 4:19 ` Bart Schaefer
2009-01-16 17:35 ` Greg Klanderman
2009-01-16 17:55 ` Peter Stephenson
2009-01-16 19:40 ` Greg Klanderman
2009-01-16 23:26 ` Richard Hartmann
2009-01-17 3:45 ` Bart Schaefer
2009-01-17 3:35 ` Bart Schaefer
2009-01-17 5:31 ` Greg Klanderman
2009-01-17 17:53 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906262123.n5QLNqJU008820@pws-pc.ntlworld.com \
--to=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).