zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <pws@csr.com>
To: zsh-workers@sunsite.dk
Cc: martin f krafft <madduck@debian.org>, 537596@bugs.debian.org
Subject: Re: Bug#537596: regression: parse error near `()' in function definition
Date: Mon, 20 Jul 2009 09:27:57 +0100	[thread overview]
Message-ID: <20090720092757.77e812c7@news01> (raw)
In-Reply-To: <20090719232041.GA5156@scru.org>

On Sun, 19 Jul 2009 23:20:41 +0000
Clint Adams <schizo@debian.org> wrote:
> On Sun, Jul 19, 2009 at 07:16:51PM +0200, martin f krafft wrote:
> > % eval 'lt() { (_lt-en $*; _en-lt $*) | more }'
> > zsh: parse error near `()'
> > 
> > Alright, so lt is special:
> > 
> > % which lt
> > lt: aliased to ls -lt

Assuming lt was defined as an alias first, this has always been the wrong
thing to do:

% alias lt="one two"
% eval 'lt() { (_lt-en $*; _en-lt $*) | more }'
% which one two
one () {
        (
                _lt-en $*
                _en-lt $*
        ) | more
}
two () {
        (
                _lt-en $*
                _en-lt $*
        ) | more
}

This is not a new feature; it's been mentioned in the FAQ for many years.


2.3: Why do my csh aliases not work?  (Plus other alias pitfalls.)

...

  There is one other serious problem with aliases: consider

    alias l='/bin/ls -F'
    l() { /bin/ls -la "$@" | more }

  `l' in the function definition is in command position and is expanded
  as an alias, defining `/bin/ls' and `-F' as functions which call
  `/bin/ls', which gets a bit recursive.  This can be avoided if you use
  `function' to define a function, which doesn't expand aliases.  It is
  possible to argue for extra warnings somewhere in this mess.

  Bart Schaefer's rule is:  Define first those aliases you expect to
  use in the body of a function, but define the function first if the
  alias has the same name as the function.

-- 
Peter Stephenson <pws@csr.com>            Software Engineer
Tel: +44 (0)1223 692070                   Cambridge Silicon Radio Limited
Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, UK


'member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom'


  parent reply	other threads:[~2009-07-20  8:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20090719171651.GA7217@piper.oerlikon.madduck.net>
2009-07-19 23:20 ` Clint Adams
2009-07-20  4:18   ` Bart Schaefer
2009-07-20  8:27   ` Peter Stephenson [this message]
2009-07-20  8:37     ` Mikael Magnusson
2009-07-20  8:50       ` Peter Stephenson
2009-07-20  9:10         ` Mikael Magnusson
2009-07-20  9:15           ` Peter Stephenson
2009-07-20  8:46     ` martin f krafft

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090720092757.77e812c7@news01 \
    --to=pws@csr.com \
    --cc=537596@bugs.debian.org \
    --cc=madduck@debian.org \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).