From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: Zsh list <zsh-workers@sunsite.dk>
Subject: Re: bug in 'b' array parameter subscript flag
Date: Sat, 5 Sep 2009 20:07:03 +0100 [thread overview]
Message-ID: <20090905200703.4cca1d21@pws-pc> (raw)
In-Reply-To: <19105.40754.702800.164855@gargle.gargle.HOWL>
On Fri, 4 Sep 2009 19:13:54 -0400
Greg Klanderman <gak@klanderman.net> wrote:
> when the 'b' flag is used with the 'i' flag, and there are no elements
> to be searched, '0' is incorrectly returned rather than one plus the
> array length:
Index: Src/params.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/params.c,v
retrieving revision 1.156
diff -u -r1.156 params.c
--- Src/params.c 8 May 2009 14:30:35 -0000 1.156
+++ Src/params.c 5 Sep 2009 19:05:21 -0000
@@ -1345,6 +1345,11 @@
len = arrlen(ta);
if (beg < 0)
beg += len;
+ if (down) {
+ if (beg < 0)
+ return 0;
+ } else if (beg >= len)
+ return len + 1;
if (beg >= 0 && beg < len) {
if (down) {
if (!hasbeg)
@@ -1363,6 +1368,11 @@
len = arrlen(ta);
if (beg < 0)
beg += len;
+ if (down) {
+ if (beg < 0)
+ return 0;
+ } else if (beg >= len)
+ return len + 1;
if (beg >= 0 && beg < len) {
if (down) {
if (!hasbeg)
Index: Test/D04parameter.ztst
===================================================================
RCS file: /cvsroot/zsh/zsh/Test/D04parameter.ztst,v
retrieving revision 1.37
diff -u -r1.37 D04parameter.ztst
--- Test/D04parameter.ztst 5 Jun 2009 11:15:53 -0000 1.37
+++ Test/D04parameter.ztst 5 Sep 2009 19:05:21 -0000
@@ -998,6 +998,34 @@
>sunny
>day
+# ' emacs likes this close quote
+
+ a=(sping spang spong bumble)
+ print ${a[(i)spong]}
+ print ${a[(i)spung]}
+ print ${a[(ib.1.)spong]}
+ print ${a[(ib.4.)spong]}
+ print ${a[(ib.10.)spong]}
+0:In and out of range reverse matched indices without and with b: arrays
+>3
+>5
+>3
+>5
+>5
+
+ a="thrimblewuddlefrong"
+ print ${a[(i)w]}
+ print ${a[(i)x]}
+ print ${a[(ib.3.)w]}
+ print ${a[(ib.10.)w]}
+ print ${a[(ib.30.)w]}
+0:In and out of range reverse matched indices without and with b: strings
+>9
+>20
+>9
+>20
+>20
+
foo="line:with::missing::fields:in:it"
print -l ${(s.:.)foo}
0:Removal of empty fields in unquoted splitting
--
Peter Stephenson <p.w.stephenson@ntlworld.com>
Web page now at http://homepage.ntlworld.com/p.w.stephenson/
next prev parent reply other threads:[~2009-09-05 19:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-04 23:13 Greg Klanderman
2009-09-05 19:07 ` Peter Stephenson [this message]
2009-09-10 3:42 ` Greg Klanderman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090905200703.4cca1d21@pws-pc \
--to=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).