From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5996 invoked from network); 22 Sep 2009 15:48:21 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 Received: from new-brage.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.254.104) by ns1.primenet.com.au with SMTP; 22 Sep 2009 15:48:21 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 52562 invoked from network); 22 Sep 2009 15:41:39 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 22 Sep 2009 15:41:39 -0000 Received: (qmail 10279 invoked by alias); 22 Sep 2009 15:41:37 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 27287 Received: (qmail 10270 invoked from network); 22 Sep 2009 15:41:36 -0000 Received: from bifrost.dotsrc.org (130.225.254.106) by sunsite.dk with SMTP; 22 Sep 2009 15:41:36 -0000 Received: from cluster-d.mailcontrol.com (cluster-d.mailcontrol.com [85.115.60.190]) by bifrost.dotsrc.org (Postfix) with ESMTPS id 2D6D0804CE03 for ; Tue, 22 Sep 2009 17:41:30 +0200 (CEST) Received: from cameurexb01.EUROPE.ROOT.PRI ([193.128.72.68]) by rly09d.srv.mailcontrol.com (MailControl) with ESMTP id n8MFf29p001479 for ; Tue, 22 Sep 2009 16:41:29 +0100 Received: from news01.csr.com ([10.99.50.25]) by cameurexb01.EUROPE.ROOT.PRI with Microsoft SMTPSVC(6.0.3790.3959); Tue, 22 Sep 2009 16:39:54 +0100 Received: from news01.csr.com (localhost.localdomain [127.0.0.1]) by news01.csr.com (8.14.2/8.13.4) with ESMTP id n8MFdsM1017687 for ; Tue, 22 Sep 2009 16:39:54 +0100 Received: from csr.com (pws@localhost) by news01.csr.com (8.14.2/8.14.2/Submit) with ESMTP id n8MFdrk8017683 for ; Tue, 22 Sep 2009 16:39:54 +0100 Message-Id: <200909221539.n8MFdrk8017683@news01.csr.com> X-Authentication-Warning: news01.csr.com: pws owned process doing -bs To: zsh-workers@sunsite.dk Subject: Re: latest from CVS segfaults when FD ulimit is set too low In-reply-to: <20090922153541.GA1717@blorf.net> References: <87iqfgwplu.fsf@meyering.net> <20090921214528.7c7b412c@pws-pc> <20090922100019.3c302758@news01> <20090922153541.GA1717@blorf.net> Comments: In-reply-to Wayne Davison message dated "Tue, 22 Sep 2009 08:35:42 -0700." Date: Tue, 22 Sep 2009 16:39:53 +0100 From: Peter Stephenson X-OriginalArrivalTime: 22 Sep 2009 15:39:54.0745 (UTC) FILETIME=[EE986E90:01CA3B9A] Content-Type: text/plain MIME-Version: 1.0 X-Scanned-By: MailControl A-06-00-00 (www.mailcontrol.com) on 10.68.0.119 X-Virus-Scanned: ClamAV 0.94.2/9822/Tue Sep 22 15:17:45 2009 on bifrost X-Virus-Status: Clean Wayne Davison wrote: > We can simplify the code a bit if we make redup() return the target fd > on success. The attached patch also adds a little more error checking > for redup(). I'll check it in later on if nobody objects. Looks OK. -- Peter Stephenson Software Engineer Tel: +44 (0)1223 692070 Cambridge Silicon Radio Limited Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, UK Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom