zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <pws@csr.com>
To: zsh-workers@sunsite.dk
Subject: Re: Rebuilding from CVS on Snow Leopard
Date: Tue, 29 Sep 2009 15:32:35 +0100	[thread overview]
Message-ID: <20090929153235.2518e630@news01> (raw)
In-Reply-To: <C9CC3A8A-BF22-46DD-A618-BFD7687F746F@kba.biglobe.ne.jp>

On Tue, 29 Sep 2009 21:05:13 +0900
"Jun T." <takimoto-j@kba.biglobe.ne.jp> wrote:
> MacOSX (and many BSD's as well?) does not define UNIX_PATH_MAX,
> and struct sockaddr_un is defined in sys/un.h as
> 
> struct  sockaddr_un {
>          unsigned char   sun_len;        /* sockaddr len including  
> null */
>          sa_family_t     sun_family;     /* [XSI] AF_UNIX */
>          char            sun_path[104];  /* [XSI] path name (gag) */
> };
> 
> so we can't define UNIX_PATH_MAX to 108.
> 
> I think it would be better to use sizeof(soun.sun_path) in place
> of UNIX_PATH_MAX. Or use sizeof(soun.sun_path)-1 so that sun_path
> is always null terminated.

Thanks, looks reasonable and I've committed it.

-- 
Peter Stephenson <pws@csr.com>            Software Engineer
Tel: +44 (0)1223 692070                   Cambridge Silicon Radio Limited
Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, UK


Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom


  reply	other threads:[~2009-09-29 14:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-28  5:50 Bart Schaefer
2009-09-29 12:05 ` Jun T.
2009-09-29 14:32   ` Peter Stephenson [this message]
2009-09-29 14:44   ` Bart Schaefer
2009-09-29 16:55     ` Jun T.
2009-09-29 17:23 ` Jun T.
2009-09-29 17:41   ` Mikael Magnusson
2009-09-30 16:11     ` Jun T.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090929153235.2518e630@news01 \
    --to=pws@csr.com \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).