From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11554 invoked by alias); 3 Nov 2009 11:32:14 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 27340 Received: (qmail 17003 invoked from network); 3 Nov 2009 11:32:01 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=ham version=3.2.5 Received-SPF: none (ns1.primenet.com.au: domain at bewatermyfriend.org does not designate permitted sender hosts) Date: Tue, 3 Nov 2009 12:24:49 +0100 From: Frank Terbeck To: zsh-workers@zsh.org Subject: Re: zsh eats 100% CPU with completion in / Message-ID: <20091103112449.GC12588@fsst.voodoo.lan> Mail-Followup-To: zsh-workers@zsh.org References: <237967ef0911011312u307ecf19kbabf9fecf867cec1@mail.gmail.com> <200911012220.nA1MKgjM005270@pws-pc.ntlworld.com> <237967ef0911011657n54279c54ja8fce16a1861ff4f@mail.gmail.com> <237967ef0911011726q7550593ax30bc61f1a736e725@mail.gmail.com> <20091102163858.11415153@news01> <237967ef0911021258x5403c976m281fb66ee7488b59@mail.gmail.com> <237967ef0911021306y33467270l6a1cf921cefbe037@mail.gmail.com> <237967ef0911021330r6f733a5v9536bbe2f237ccf9@mail.gmail.com> <20091103101058.2eeaf4b6@news01> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20091103101058.2eeaf4b6@news01> User-Agent: Mutt/1.5.18 (2008-05-17) X-Df-Sender: 430444 Peter Stephenson : > On Mon, 2 Nov 2009 22:30:08 +0100 > Mikael Magnusson wrote: > > > And this seems to fix it. Not sure if checking that inside the loop is the best > > > place, but there seems to be some freeing of *pp going on that I > > > didn't feel like > > > investigating. Maybe checking xbuf before slashsplit would work? > > > > And of course, I have no idea if *xbuf being '\0' is indicative of > > some other bug. > > Thanks, it looks like that really is the problem and I think the fix is > fine. [...] My colleague just tried this and it seems like it fixes the bug for him, too. Thanks for wading through the code and coming up with a fix, Mikael! :-) Regards, Frank