From: "Štěpán Němec" <stepnem@gmail.com>
To: "Alexey I. Froloff" <raorn@altlinux.org>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] _git: offer changed files relative to current directory
Date: Tue, 8 Dec 2009 14:20:10 +0100 [thread overview]
Message-ID: <20091208132010.GF21684@headley> (raw)
In-Reply-To: <20091208120849.GG9335@altlinux.org>
On Tue, Dec 08, 2009 at 03:08:49PM +0300, Alexey I. Froloff wrote:
> On Sat, Dec 05, 2009 at 06:00:53PM +0100, ??t??p??n N??mec wrote:
> > - _wanted files expl 'index file' _multi_parts $@ - / files
> > + _description files expl 'Changed files'
> > + compadd "$expl[@]" - "$files[@]"
> You don't use _multi_parts, what's why you think my code is
> "wrong".
Yeah, I figured as much; it's "wrong" only with respect to my
expectations, of course -- I also noted already that your solution
actually seems to be more consistent with other Zsh behaviour.
My solution actually duplicates the output of `git status', so it
displays and completes the whole paths immediately, at any position
within the repository. I still think it's (more) convenient and I kind
of got used to it, but the code is ridiculous and I assume others prefer
the behaviour of your solution, too.
Thanks to all for input, also to Mikael for the one-keystroke-saving
suggestion ;-).
Regards,
Štěpán
next prev parent reply other threads:[~2009-12-08 13:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-05 0:32 Alexey I. Froloff
2009-12-05 12:07 ` Štěpán Němec
2009-12-05 12:42 ` Alexey I. Froloff
2009-12-05 15:12 ` Alexey I. Froloff
2009-12-05 17:00 ` Štěpán Němec
2009-12-05 17:45 ` Alexey I. Froloff
2009-12-06 21:52 ` [PATCH] _git: offer " Alexey I. Froloff
2009-12-07 22:40 ` Alexey I. Froloff
2009-12-08 10:48 ` Štěpán Němec
2009-12-08 10:50 ` Nikolai Weibull
2009-12-08 11:37 ` Štěpán Němec
2009-12-08 11:45 ` Mikael Magnusson
2009-12-08 11:22 ` Alexey I. Froloff
2009-12-08 11:39 ` Štěpán Němec
2009-12-08 12:07 ` Alexey I. Froloff
2009-12-13 0:08 ` Alexey I. Froloff
2009-12-13 21:33 ` Peter Stephenson
2009-12-13 22:16 ` Nikolai Weibull
2009-12-13 22:22 ` Štěpán Němec
2009-12-14 13:20 ` Jörg Sommer
2009-12-08 12:08 ` [PATCH] _git: offer changed " Alexey I. Froloff
2009-12-08 13:20 ` Štěpán Němec [this message]
2009-12-08 13:30 ` Alexey I. Froloff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091208132010.GF21684@headley \
--to=stepnem@gmail.com \
--cc=raorn@altlinux.org \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).