zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <pws@csr.com>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] run-help: ugly workaround for run-help-$X with alias for $X
Date: Wed, 16 Dec 2009 10:57:25 +0000	[thread overview]
Message-ID: <20091216105725.010c00d9@news01> (raw)
In-Reply-To: <091214075055.ZM8191@torch.brasslantern.com>

On Mon, 14 Dec 2009 07:50:55 -0800
Bart Schaefer <schaefer@brasslantern.com> wrote:
> That unset is probably there because older versions of zsh had some
> bugs in the implementation of "var=value command ..." particularly in
> the case where "command" is a function or builtin.  This stemmed from
> zsh's efforts to avoid forking when no external program was involved.

Actually, it's here (from the diff -u)...

+		unset run_help_orig_cmd
 		eval "run-help-$1:t ${(qq@)cmd_args[2,-1]}"

... so maybe I've missed the point:  it may have been to prevent
$run_help_orig_cmd being seen by run-help-<something>.  However, that seems
unlikely since (i) there's no reason they'd be confused by it (ii) they
might even find it useful.

I'll (finally) commit what's there at the moment and see what happens.

-- 
Peter Stephenson <pws@csr.com>            Software Engineer
Tel: +44 (0)1223 692070                   Cambridge Silicon Radio Limited
Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, UK


Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom


  parent reply	other threads:[~2009-12-16 10:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-14 11:40 Jörg Sommer
2009-12-14 13:42 ` Peter Stephenson
2009-12-14 15:50   ` Bart Schaefer
2009-12-14 16:38     ` Andrey Borzenkov
2009-12-14 17:01       ` Bart Schaefer
2009-12-16 10:57     ` Peter Stephenson [this message]
2009-12-18 13:51       ` Jörg Sommer
  -- strict thread matches above, loose matches on Subject: below --
2009-12-07  0:57 Jörg Sommer
2009-12-10  9:49 ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091216105725.010c00d9@news01 \
    --to=pws@csr.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).