zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: zsh-workers@zsh.org
Subject: Re: PATCH: installing executable functions
Date: Sun, 31 Jan 2010 19:57:28 +0000	[thread overview]
Message-ID: <20100131195728.3985ed21@pws-pc> (raw)
In-Reply-To: <201001300835.14068.arvidjaar@gmail.com>

On Sat, 30 Jan 2010 08:35:03 +0300
Andrey Borzenkov <arvidjaar@gmail.com> wrote:
> read -r line < $sdir_top/$file
> case "$line" in
>     '#!'* )
> 		chmod +x $instdir/`echo $file | sed -e 's%^.*/%%'`
> 	;;
> esac

This looks pretty good: we already rely on "case" heavily in
configure...  I'm a trifle worried about "read -r" in case some perverse
Bourne shell doesn't handle the "-r", and since we don't want spaces or
backslashes etc.  I don't think it's necessary... any theories / further
suggestions?

-- 
Peter Stephenson <p.w.stephenson@ntlworld.com>
Web page now at http://homepage.ntlworld.com/p.w.stephenson/


      reply	other threads:[~2010-01-31 19:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-29 21:54 Peter Stephenson
2010-01-30  0:36 ` Bart Schaefer
2010-01-30  5:35   ` Andrey Borzenkov
2010-01-31 19:57     ` Peter Stephenson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100131195728.3985ed21@pws-pc \
    --to=p.w.stephenson@ntlworld.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).