From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5118 invoked by alias); 31 Jan 2010 19:57:39 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 27646 Received: (qmail 23364 invoked from network); 31 Jan 2010 19:57:37 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 Received-SPF: pass (ns1.primenet.com.au: SPF record at ntlworld.com designates 81.103.221.47 as permitted sender) Date: Sun, 31 Jan 2010 19:57:28 +0000 From: Peter Stephenson To: zsh-workers@zsh.org Subject: Re: PATCH: installing executable functions Message-ID: <20100131195728.3985ed21@pws-pc> In-Reply-To: <201001300835.14068.arvidjaar@gmail.com> References: <25809.1264802076@pws-pc> <100129163645.ZM9106@torch.brasslantern.com> <201001300835.14068.arvidjaar@gmail.com> X-Mailer: Claws Mail 3.7.4 (GTK+ 2.18.6; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Cloudmark-Analysis: v=1.1 cv=1ggfb5FlKZQUfF3vzm9UBYZ2uTfLsbs/8dSljwg5+mE= c=1 sm=0 a=RrdiydZLxYYA:10 a=pGLkceISAAAA:8 a=NLZqzBF-AAAA:8 a=FkwoQKElmUaMwSBQjogA:9 a=1z2QItRbSTeUTMJm-tVlJ2BdaI4A:4 a=MSl-tDqOz04A:10 a=_dQi-Dcv4p4A:10 a=HpAAvcLHHh0Zw7uRqdWCyQ==:117 On Sat, 30 Jan 2010 08:35:03 +0300 Andrey Borzenkov wrote: > read -r line < $sdir_top/$file > case "$line" in > '#!'* ) > chmod +x $instdir/`echo $file | sed -e 's%^.*/%%'` > ;; > esac This looks pretty good: we already rely on "case" heavily in configure... I'm a trifle worried about "read -r" in case some perverse Bourne shell doesn't handle the "-r", and since we don't want spaces or backslashes etc. I don't think it's necessary... any theories / further suggestions? -- Peter Stephenson Web page now at http://homepage.ntlworld.com/p.w.stephenson/