zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <pws@csr.com>
To: Roy Marples <roy@NetBSD.org>
Cc: zsh-workers@zsh.org
Subject: Re: termcap/terminfo includes
Date: Mon, 8 Feb 2010 10:50:12 +0000	[thread overview]
Message-ID: <20100208105012.6417d49d@news01> (raw)
In-Reply-To: <4B6EA9B1.4030001@NetBSD.org>

On Sun, 07 Feb 2010 11:53:21 +0000
Roy Marples <roy@NetBSD.org> wrote:
> NetBSD recently gained terminfo and zsh is now failing to build.
> The exact error is due to a zsh definition vs our curses.h underscore() 
> function.
> 
> Looking through the code, I see no reason why either termcap or terminfo 
> code should include curses header as no curses calls are made.
> Also, it is an unsafe assumption that either curses.h or term.h pulls in 
> termcap.h for the function decs.

Nothing is a safe assumption with the terminal headers, which took years to
get to compile cleanly on multiple systems with very different interactions
between the headers.  The result isn't logical but without actually trying
changes on heaps of systems (which I don't have access to) we're stuck with
that.  In particular removing lots of #ifdef tests for things probed by
configure isn't safe.

Please could you send a minimal change to fix your problem?  A generic
solution is obviously better (though fraught for the reasons above) but
we'll certainly make do with a system-specific test.

Thanks.

-- 
Peter Stephenson <pws@csr.com>            Software Engineer
Tel: +44 (0)1223 692070                   Cambridge Silicon Radio Limited
Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, UK


Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom


  reply	other threads:[~2010-02-08 11:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-07 11:53 Roy Marples
2010-02-08 10:50 ` Peter Stephenson [this message]
2010-02-08 22:45   ` Geoff Wing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100208105012.6417d49d@news01 \
    --to=pws@csr.com \
    --cc=roy@NetBSD.org \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).