From: Andrey Borzenkov <arvidjaar@gmail.com>
To: zsh-workers@zsh.org
Cc: Michael Hwang <michael.a.hwang@gmail.com>
Subject: Re: LinkList implementation
Date: Sun, 28 Feb 2010 12:06:47 +0300 [thread overview]
Message-ID: <201002281206.53953.arvidjaar@gmail.com> (raw)
In-Reply-To: <22a0ef081002271433u713e1923lb04c7d1bf369d3d0@mail.gmail.com>
[-- Attachment #1: Type: Text/Plain, Size: 1022 bytes --]
On Sunday 28 of February 2010 01:33:24 Michael Hwang wrote:
> In the process of writing a new builtin, I discovered an oddity of
> zsh's implementation of LinkList, which is a doubly linked list.
>
> LinkList alist = newlinklist();
> LinkNode node;
> for (node = lastnode(alist); node; decnode(alist)) {
> ((SomeStructPointer) getdata(node))->someField;
> }
>
BTW decnode applies to node, not list - it should be decnode(node)
> Since no nodes have been added to the LinkList, one would expect the
> body of the loop to not run at all.
Well, you have to accept that and use another termination condition,
like e.g. in zle_hist.c:isearch_newpos():
for (node = lastnode(matchlist);
node != (LinkNode)matchlist; decnode(node)) {
For the sake of purity this actually should be
node != &matchlist->node
The games linklist.c plays are really daunting ... but to change it now
you have to carefully go through all of code to adjust snippets like
above.
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2010-02-28 9:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-27 22:33 Michael Hwang
2010-02-27 22:45 ` Michael Hwang
2010-02-28 9:06 ` Andrey Borzenkov [this message]
2010-03-01 18:00 ` Michael Hwang
2010-03-01 18:12 ` Peter Stephenson
2010-03-06 3:48 ` [PATCH] Added LinkList documentation to linklist.c Michael Hwang
2010-03-07 21:36 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201002281206.53953.arvidjaar@gmail.com \
--to=arvidjaar@gmail.com \
--cc=michael.a.hwang@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).