From: Peter Stephenson <pws@csr.com>
To: zsh-workers@zsh.org
Subject: Re: LinkList implementation
Date: Mon, 01 Mar 2010 18:12:30 +0000 [thread overview]
Message-ID: <201003011812.o21ICUCu026435@news01.csr.com> (raw)
In-Reply-To: <22a0ef081003011000o36e85e27id29136a793347f8c@mail.gmail.com>
Michael Hwang wrote:
> I solved my problem by simply reversing the direction I added on to
> the LinkList, and therefore the direction I walked through it. I'll
> see if I can't make the LinkList implementation simpler and more
> intuitive. These "gotcha!"'s are a bit annoying.
If you're doing *anything* to the linked list code, the first imperative
is documenting what it currently does. I'm not interested in improving
it until it's clearly written in <your foreground colour> and <your
background colour> what it is that's being improved.
To get on my high horse, in fact the first and last imperative with lots
of the code is better documentation. I have wasted days of my life
having to puzzle things out.
--
Peter Stephenson <pws@csr.com> Software Engineer
Tel: +44 (0)1223 692070 Cambridge Silicon Radio Limited
Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, UK
Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
next prev parent reply other threads:[~2010-03-01 18:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-27 22:33 Michael Hwang
2010-02-27 22:45 ` Michael Hwang
2010-02-28 9:06 ` Andrey Borzenkov
2010-03-01 18:00 ` Michael Hwang
2010-03-01 18:12 ` Peter Stephenson [this message]
2010-03-06 3:48 ` [PATCH] Added LinkList documentation to linklist.c Michael Hwang
2010-03-07 21:36 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201003011812.o21ICUCu026435@news01.csr.com \
--to=pws@csr.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).