From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6885 invoked by alias); 1 Mar 2010 18:22:35 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 27764 Received: (qmail 20007 invoked from network); 1 Mar 2010 18:22:32 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00, RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=ham version=3.2.5 Received-SPF: none (ns1.primenet.com.au: domain at csr.com does not designate permitted sender hosts) Message-Id: <201003011812.o21ICUCu026435@news01.csr.com> X-Authentication-Warning: news01.csr.com: pws owned process doing -bs To: zsh-workers@zsh.org Subject: Re: LinkList implementation In-reply-to: <22a0ef081003011000o36e85e27id29136a793347f8c@mail.gmail.com> References: <22a0ef081002271433u713e1923lb04c7d1bf369d3d0@mail.gmail.com> <201002281206.53953.arvidjaar@gmail.com> <22a0ef081003011000o36e85e27id29136a793347f8c@mail.gmail.com> Comments: In-reply-to Michael Hwang message dated "Mon, 01 Mar 2010 13:00:56 -0500." Date: Mon, 01 Mar 2010 18:12:30 +0000 From: Peter Stephenson X-OriginalArrivalTime: 01 Mar 2010 18:12:33.0694 (UTC) FILETIME=[C3D923E0:01CAB96A] Content-Type: text/plain MIME-Version: 1.0 X-Scanned-By: MailControl A-09-22-10 (www.mailcontrol.com) on 10.68.0.120 Michael Hwang wrote: > I solved my problem by simply reversing the direction I added on to > the LinkList, and therefore the direction I walked through it. I'll > see if I can't make the LinkList implementation simpler and more > intuitive. These "gotcha!"'s are a bit annoying. If you're doing *anything* to the linked list code, the first imperative is documenting what it currently does. I'm not interested in improving it until it's clearly written in and what it is that's being improved. To get on my high horse, in fact the first and last imperative with lots of the code is better documentation. I have wasted days of my life having to puzzle things out. -- Peter Stephenson Software Engineer Tel: +44 (0)1223 692070 Cambridge Silicon Radio Limited Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, UK Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom