From: Simon Ruderich <simon@ruderich.org>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] _git: Also complete FETCH_HEAD, ORIG_HEAD and MERGE_HEAD.
Date: Mon, 22 Mar 2010 02:25:44 +0100 [thread overview]
Message-ID: <20100322012544.GA6014@ruderich.org> (raw)
In-Reply-To: <dbfc82861003211317t7617b83ex2be594d2d994f328@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 754 bytes --]
On Sun, Mar 21, 2010 at 09:17:25PM +0100, Nikolai Weibull wrote:
> On Sun, Mar 21, 2010 at 20:48, Benjamin R. Haskell wrote:
>
>> + symbolic_heads=()
>> + for head in HEAD ORIG_HEAD FETCH_HEAD MERGE_HEAD ; do
>> + git rev-parse $head &>/dev/null && symbolic_heads+=( $head )
>> + done
>
> That’s a lot of forking to make a simple check. Is there no better
> way? Do we actually have to filter the heads?
I don't know the _git completion code, but couldn't we just check
if .git/{ORIG_HEAD,FETCH_HEAD,MERGE_HEAD} exists? This should
work for most things.
Another possibility would be to just complete them all the time.
Simon
--
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
next prev parent reply other threads:[~2010-03-22 1:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-21 17:23 Simon Ruderich
2010-03-21 19:48 ` Benjamin R. Haskell
2010-03-21 20:17 ` Nikolai Weibull
2010-03-22 1:25 ` Simon Ruderich [this message]
2010-03-22 2:30 ` Benjamin R. Haskell
2010-03-22 9:27 ` Nikolai Weibull
2010-03-29 0:07 ` Simon Ruderich
2010-05-01 8:28 ` Simon Ruderich
2010-05-01 10:46 ` Frank Terbeck
2010-05-01 12:12 ` Simon Ruderich
2010-05-01 12:17 ` Frank Terbeck
2010-05-01 20:32 ` Simon Ruderich
2010-05-02 9:04 ` Frank Terbeck
2010-05-03 14:51 ` Benjamin R. Haskell
2010-03-29 13:56 ` Benjamin R. Haskell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100322012544.GA6014@ruderich.org \
--to=simon@ruderich.org \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).