zsh-workers
 help / color / mirror / code / Atom feed
From: Vincent Lefevre <vincent@vinc17.net>
To: zsh-workers@zsh.org
Subject: Re: zsh 4.3.10 history-incremental-search-backward freezes in UTF-8
Date: Thu, 25 Mar 2010 17:43:23 +0100	[thread overview]
Message-ID: <20100325164322.GA29589@prunille.vinc17.org> (raw)
In-Reply-To: <20100318154424.706b6c16@news01>

On 2010-03-18 15:44:24 +0000, Peter Stephenson wrote:
> Index: Src/Zle/zle_hist.c
> ===================================================================
> RCS file: /cvsroot/zsh/zsh/Src/Zle/zle_hist.c,v
> retrieving revision 1.63
> diff -p -u -r1.63 zle_hist.c
> --- Src/Zle/zle_hist.c	6 Sep 2009 21:37:14 -0000	1.63
> +++ Src/Zle/zle_hist.c	18 Mar 2010 15:42:53 -0000
> @@ -1454,6 +1454,8 @@ doisearch(char **args, int dir, int patt
>  	    memset(&mbs, 0, sizeof(mbs));
>  	    while (charpos < end_pos) {
>  		ret = mb_metacharlenconv_r(zlemetaline + charpos, &wc, &mbs);
> +		if (ret <= 0) /* Unrecognised, treat as single char */
> +		    ret = 1;
>  		if (charpos <= pos && pos < charpos + ret)
>  		    isearch_startpos = charcount;
>  		charcount++;

Since I've recompiled zsh to use this patch, zsh crashes more and
more often under Mac OS X (under ISO-8859-1 locales). I'll try the
new one...

-- 
Vincent Lefèvre <vincent@vinc17.net> - Web: <http://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <http://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / Arénaire project (LIP, ENS-Lyon)


  parent reply	other threads:[~2010-03-25 16:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-18 10:50 Vincent Lefevre
2010-03-18 14:30 ` Peter Stephenson
2010-03-18 15:20   ` Vincent Lefevre
2010-03-18 15:44     ` Peter Stephenson
2010-03-20  0:29       ` PATCH: Displaying invalid characters Peter Stephenson
2010-03-25 16:43       ` Vincent Lefevre [this message]
2010-03-18 14:55 ` zsh 4.3.10 history-incremental-search-backward freezes in UTF-8 Bart Schaefer
2010-03-18 15:24   ` Vincent Lefevre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100325164322.GA29589@prunille.vinc17.org \
    --to=vincent@vinc17.net \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).