From: Phil Pennock <zsh-workers+phil.pennock@spodhuis.org>
To: Frank Terbeck <ft@bewatermyfriend.org>
Cc: zsh-workers@zsh.org
Subject: Re: vcs_info and locales
Date: Sun, 25 Apr 2010 06:19:44 -0700 [thread overview]
Message-ID: <20100425131944.GA55789@redoubt.spodhuis.org> (raw)
In-Reply-To: <87aassncyk.fsf@ft.bewatermyfriend.org>
On 2010-04-25 at 10:38 +0200, Frank Terbeck wrote:
> Anyway, could you try the following patch for the locale problem? I
> think it should solve the issue once and for all.
I have one concern, which leads to the question: is it really necessary
to set LC_ALL instead of LC_MESSAGES?
The main problem is that when you override LC_CTYPE to C, you lose any
potential UTF-8 support, unless the tool just passes through the binary
data.
I think the safest algorithm is not to set LC_ALL but instead:
* set LC_MESSAGES=C
* if LC_ALL is set and is not C, set LANG=$LC_ALL, unset LC_ALL
Make sense?
Rest of this email is just some exploration and skippable.
I don't have NLS support on my main box, or I could do more testing
myself; with { svn log }, where most of my UTF-8 shows, LC_CTYPE=C leads
to expressing the content with escapes instead of cleanly. I know
VCS_Info doesn't use that, I mention it by way of example. { svn info }
by contrast always percent-encodes those characters; this works anyway,
because VCS_Info walks back up the dir-tree to find the svn co dir, so
has the relative info by comparing the FS realpath'd root of the repo to
the current dir.
URL: https://svn.spodhuis.org/ksvn/scratch/Fran%C3%A7ois
-> VCS_Info %S == François
(yes, I picked the OP's name as example testdata)
For experimentation, I created a repo with a UTF-8 character in its
name. Apache/mod_dav_svn won't serve it:
(20014)Internal error: Can't convert string from 'UTF-8' to native encoding: [...]
but I can use file:/// access instead. A repo named foo-☺ appears in my
prompt as <foo-%E2%98%BA:0> (<name:version>).
And still VCS_Info works:
URL: file:///home/pdp/tmp/T/ROOT/foo-%E2%98%BA/fred
Repository Root: file:///home/pdp/tmp/T/ROOT/foo-%E2%98%BA
-> VCS_Info %S == fred
pwd -> ..../T/foo-☺/fred
URL: file:///home/pdp/tmp/T/ROOT/foo-%E2%98%BA/%E2%99%A1
Repository Root: file:///home/pdp/tmp/T/ROOT/foo-%E2%98%BA
-> VCS_Info %S == ♡
pwd -> ..../T/foo-☺/♡
I ♡ VCS_Info for just working, but it's still juju. It also works as
an accidental artifact of the VCS_INFO_get_data_svn implementation. I
get to say "accidental" because apparently I wrote that code.
*scratches head*
(Through all this, cd gets interesting when xtitle updates to iTerm
silently drop the UTF-8 characters through to the display)
next prev parent reply other threads:[~2010-04-25 13:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-24 21:40 François Gannaz
2010-04-25 8:38 ` Frank Terbeck
2010-04-25 10:36 ` François Gannaz
2010-04-25 13:19 ` Phil Pennock [this message]
2010-04-25 14:09 ` Frank Terbeck
2010-04-25 14:29 ` Frank Terbeck
2010-05-19 10:07 ` Richard Hartmann
2010-05-19 11:50 ` François Gannaz
2010-05-19 12:03 ` Richard Hartmann
2010-04-25 19:09 ` François Gannaz
2010-04-26 0:29 ` Phil Pennock
2010-04-26 6:36 ` Frank Terbeck
2010-04-26 8:56 ` François Gannaz
2010-04-26 19:07 ` Frank Terbeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100425131944.GA55789@redoubt.spodhuis.org \
--to=zsh-workers+phil.pennock@spodhuis.org \
--cc=ft@bewatermyfriend.org \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).