From: "François Gannaz" <francois.gannaz@free.fr>
To: zsh-workers@zsh.org
Subject: Re: vcs_info and locales
Date: Sun, 25 Apr 2010 21:09:22 +0200 [thread overview]
Message-ID: <20100425210922.13596c4f@coriolan> (raw)
In-Reply-To: <20100425131944.GA55789@redoubt.spodhuis.org>
Le 2010-04-25, Phil Pennock <zsh-workers+phil.pennock@spodhuis.org> a écrit :
> On 2010-04-25 at 10:38 +0200, Frank Terbeck wrote:
> > Anyway, could you try the following patch for the locale problem? I
> > think it should solve the issue once and for all.
>
> I have one concern, which leads to the question: is it really necessary
> to set LC_ALL instead of LC_MESSAGES?
Yes it is. I used LC_ALL here because that was the only one that made "svn
info" switch to English when default locale is set to "fr_FR.utf8".
% LC_ALL=C svn info
Path: .
[...]
% LC_MESSAGES=C LANG=C LC_CTYPE=C svn info
Chemin : .
[...]
> The main problem is that when you override LC_CTYPE to C, you lose any
> potential UTF-8 support, unless the tool just passes through the binary
> data.
>
> I think the safest algorithm is not to set LC_ALL but instead:
> * set LC_MESSAGES=C
> * if LC_ALL is set and is not C, set LANG=$LC_ALL, unset LC_ALL
>
> Make sense?
I had not tested what non-ASCII encoding became, and you're right that the
shell can't handle utf-8 anymore.
% LC_ALL=C svn log
------------------------------------------------------------------------
r1 | zamansky | 2010-04-25 20:46:26 +0200 (Sun, 25 Apr 2010) | 2 lines
Accentu?\195?\169 l?\195?\160 aussi. ?\195?\128 tester.
So setting LC_ALL=C globally is indeed a bad idea. But why not just locally in
VCS_INFO_get_data_svn? I don't think that behavior would hurt much vcs_info.
The only problem I can think of is when the repository name is not un ASCII,
and doing this really calls for troubles ;-)
With a "françois" repository and LC_ALL=C:
% vcs_info command ; vcs_info_lastmsg
$vcs_info_msg_0_: "svn:(franfrançois37ois:1) "
The other solution would be to use the line numbers to fetch the data from "svn
info".
--
François
next prev parent reply other threads:[~2010-04-25 19:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-24 21:40 François Gannaz
2010-04-25 8:38 ` Frank Terbeck
2010-04-25 10:36 ` François Gannaz
2010-04-25 13:19 ` Phil Pennock
2010-04-25 14:09 ` Frank Terbeck
2010-04-25 14:29 ` Frank Terbeck
2010-05-19 10:07 ` Richard Hartmann
2010-05-19 11:50 ` François Gannaz
2010-05-19 12:03 ` Richard Hartmann
2010-04-25 19:09 ` François Gannaz [this message]
2010-04-26 0:29 ` Phil Pennock
2010-04-26 6:36 ` Frank Terbeck
2010-04-26 8:56 ` François Gannaz
2010-04-26 19:07 ` Frank Terbeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100425210922.13596c4f@coriolan \
--to=francois.gannaz@free.fr \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).