* [PATCH] git log's "branch" argument is optional @ 2010-06-06 11:40 Holger Weiss 2010-07-24 10:36 ` Simon Ruderich 0 siblings, 1 reply; 3+ messages in thread From: Holger Weiss @ 2010-06-06 11:40 UTC (permalink / raw) To: Zsh Workers This patch fixes the problem that "git log f<Tab>" currently doesn't complete file names. --- Completion/Unix/Command/_git | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Completion/Unix/Command/_git b/Completion/Unix/Command/_git index cb06d57..ccf29a4 100644 --- a/Completion/Unix/Command/_git +++ b/Completion/Unix/Command/_git @@ -1871,7 +1871,7 @@ _git-log () { case $state in (files) _arguments -S \ - ':branch:__git_commit_ranges2' \ + '::branch:__git_commit_ranges2' \ '*:index file:__git_cached_files' && ret=0 ;; esac -- Holger ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] git log's "branch" argument is optional 2010-06-06 11:40 [PATCH] git log's "branch" argument is optional Holger Weiss @ 2010-07-24 10:36 ` Simon Ruderich 2010-07-24 19:06 ` Wayne Davison 0 siblings, 1 reply; 3+ messages in thread From: Simon Ruderich @ 2010-07-24 10:36 UTC (permalink / raw) To: zsh-workers [-- Attachment #1: Type: text/plain, Size: 383 bytes --] On Sun, Jun 06, 2010 at 01:40:12PM +0200, Holger Weiss wrote: > This patch fixes the problem that "git log f<Tab>" currently doesn't > complete file names. > > [snip] Could this patch please get applied? It works fine for me and fixes the mentioned problem. Thanks, Simon -- + privacy is necessary + using gnupg http://gnupg.org + public key id: 0x92FEFDB7E44C32F9 [-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] git log's "branch" argument is optional 2010-07-24 10:36 ` Simon Ruderich @ 2010-07-24 19:06 ` Wayne Davison 0 siblings, 0 replies; 3+ messages in thread From: Wayne Davison @ 2010-07-24 19:06 UTC (permalink / raw) To: Simon Ruderich; +Cc: zsh-workers [-- Attachment #1: Type: text/plain, Size: 458 bytes --] On Sat, Jul 24, 2010 at 3:36 AM, Simon Ruderich <simon@ruderich.org> wrote: > Could this patch please get applied? It works fine for me and > fixes the mentioned problem. > I've committed the change. I hadn't noticed the problem because I use an alias lo='git log --patience', and that apparently by-passes the branch completion. Indeed, it is impossible to complete a branch name after an option, so we'll need to look into fixing that next. ..wayne.. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-07-24 19:06 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2010-06-06 11:40 [PATCH] git log's "branch" argument is optional Holger Weiss 2010-07-24 10:36 ` Simon Ruderich 2010-07-24 19:06 ` Wayne Davison
Code repositories for project(s) associated with this public inbox https://git.vuxu.org/mirror/zsh/ This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).