From: Simon Ruderich <simon@ruderich.org>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] Update feh completion for feh 1.6
Date: Mon, 7 Jun 2010 00:37:46 +0200 [thread overview]
Message-ID: <20100606223746.GA23232@ruderich.org> (raw)
In-Reply-To: <20100601155155.GA4687@derf.homelinux.org>
[-- Attachment #1: Type: text/plain, Size: 1189 bytes --]
On Tue, Jun 01, 2010 at 05:51:55PM +0200, Daniel Friesel wrote:
> Heya,
>
> I updated the feh completion, it'd be nice if someone could
> commit that to the repo.
>
> --derf
> [snip]
>
> for arg in ${(k)argument_pairs}; {
> - arguments+='(--'$arg')-'${argument_pairs[$arg]}${argument_postfix[$arg]}
> + arguments+='(--'${arg}')-'${argument_pairs[$arg]}${argument_postfix[$arg]}
> arguments+='(-'${argument_pairs[$arg]}[1]')--'${arg}${argument_postfix[$arg]}
> }
>
> [snip]
Looks like this wasn't committed correctly. Here is a patch which
should fix it.
--- a/Completion/Unix/Command/_feh
+++ b/Completion/Unix/Command/_feh
@@ -164,7 +164,8 @@ arguments=(
)
for arg in ${(k)argument_pairs}; {
- arguments+='(--'${arg}')-'${argument_pairs[$arg]}${argument_postfix[$arg arguments+='(-'${argument_pairs[$arg]}[1]')--'${arg}${argument_postfix[$arg]}
+ arguments+='(--'${arg}')-'${argument_pairs[$arg]}${argument_postfix[$arg]}
+ arguments+='(-'${argument_pairs[$arg]}[1]')--'${arg}${argument_postfix[$arg]}
}
function _feh_theme {
Thanks,
Simon
--
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
next prev parent reply other threads:[~2010-06-06 22:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-01 15:51 Daniel Friesel
2010-06-06 22:37 ` Simon Ruderich [this message]
2010-06-07 5:03 ` Doug Kearns
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100606223746.GA23232@ruderich.org \
--to=simon@ruderich.org \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).