From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12984 invoked by alias); 6 Jun 2010 22:42:56 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 28002 Received: (qmail 16480 invoked from network); 6 Jun 2010 22:42:54 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 Received-SPF: pass (ns1.primenet.com.au: SPF record at ruderich.org designates 78.46.69.5 as permitted sender) Date: Mon, 7 Jun 2010 00:37:46 +0200 From: Simon Ruderich To: zsh-workers@zsh.org Subject: Re: [PATCH] Update feh completion for feh 1.6 Message-ID: <20100606223746.GA23232@ruderich.org> References: <20100601155155.GA4687@derf.homelinux.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=_zucker.schokokeks.org-25303-1275863862-0001-2" Content-Disposition: inline In-Reply-To: <20100601155155.GA4687@derf.homelinux.org> User-Agent: Mutt/1.5.20 (2010-05-08) --=_zucker.schokokeks.org-25303-1275863862-0001-2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 01, 2010 at 05:51:55PM +0200, Daniel Friesel wrote: > Heya, > > I updated the feh completion, it'd be nice if someone could > commit that to the repo. > > --derf > [snip] > > for arg in ${(k)argument_pairs}; { > - arguments+=3D'(--'$arg')-'${argument_pairs[$arg]}${argument_postfix[$ar= g]} > + arguments+=3D'(--'${arg}')-'${argument_pairs[$arg]}${argument_postfix[$= arg]} > arguments+=3D'(-'${argument_pairs[$arg]}[1]')--'${arg}${argument_postfi= x[$arg]} > } > > [snip] Looks like this wasn't committed correctly. Here is a patch which should fix it. --- a/Completion/Unix/Command/_feh +++ b/Completion/Unix/Command/_feh @@ -164,7 +164,8 @@ arguments=3D( ) for arg in ${(k)argument_pairs}; { - arguments+=3D'(--'${arg}')-'${argument_pairs[$arg]}${argument_postfix[$ar= g arguments+=3D'(-'${argument_pairs[$arg]}[1]')--'${arg}${argument_postfix[= $arg]} + arguments+=3D'(--'${arg}')-'${argument_pairs[$arg]}${argument_postfix[$ar= g]} + arguments+=3D'(-'${argument_pairs[$arg]}[1]')--'${arg}${argument_postfix[= $arg]} } function _feh_theme { Thanks, Simon --=20 + privacy is necessary + using gnupg http://gnupg.org + public key id: 0x92FEFDB7E44C32F9 --=_zucker.schokokeks.org-25303-1275863862-0001-2 Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iQIcBAEBCAAGBQJMDCM6AAoJEJL+/bfkTDL5U1QP+wXoaIgBMJAhJX54xX1lnoSI 4un2bE0dSXsrfxjqqTkp2LE111Aj1cLkSHkRTWLj6ljmksW5L9lTBIEN7gzvhOif L4TaZFycYXUviNPl0pU8eWYxX0WflrphcZ1AY6EfwCvTGpVPWW2h8zeNR7ybLmP8 xMAVwLB9jNGJK6CelHb5F7geN/MO8HeEoEUxclNsTODeY3gFnyrZoJizgBQrBGnO UqHrf7bNpAdky7zw6KRGKB+o2E8DGrtSxY9QgyxsQY6AW5+QCXla5kxQGGuGhU4h TJIqTlxObNCoHXtg+7au1dwjwlux079HBYj3dHIXQzLM3kohSGBYSCR5WKJImMn0 4QcGAPEFnZJxBnC0gGnuKlorq1zRKsJ4hw+iAAjTJEKG+yzKccJaWJidXZ6uy4y/ aYXxZqKxI+tMv2rikGD3QNm5gkWqhpMTL2ficur8WLSp9jfKdhFRWrDiLZsdl0cv JWfF1Y565r0UBSDYRJQgbMoRDTTatERHhzi5jY3O3yG84FVowQag5g9sFSs/QptG UEn57n4dklBr5KUYceFhmx47T+4URJuopfAQrx2bCu2Z/2eOooIsxKqutGOkNdZn 4J39r/DoW6cMgtbp1TLGASaH2Xqcf8NV8nON+AyhBEUV03apJvYoAfjruzToIg5X XSSft69Z0lQ5A0rwVPFc =Hq2F -----END PGP SIGNATURE----- --=_zucker.schokokeks.org-25303-1275863862-0001-2--