Re: PATCH: Add $OVERSTRIKE in zle widgets

[Peter Stephenson <Peter.Stephenson@csr.com>]

On Tue,  3 Aug 2010 02:57:33 +0200
Frank Terbeck <ft@bewatermyfriend.org> wrote:
> This adds a read-only integer parameter `$OVERSTRIKE' to the set of
> special parameters available in zle-widgets. Since `zle-keymap-select'
> is a widget, it has access to the parameter. That makes it trivial to
> set $psvar[1] to "r" if zle is in overstrike mode.
> 
> 
> Do others think that's useful enough to have in zsh?

One think I'd suggest is using OVERWRITE instead of OVERSTRIKE, since
that's what the corresponding zle widget is called; there's no use of
"overstrike" in the documentation at present, and it vaguely suggests to me
a visual effect such as two characters on top of one another or a line
through.  You might also want to refer to the overwrite-mode widget.

Apart from that, this looks useful; the only thing that might make a
difference is if there was some other information that could be combined
with this and the result presented in a more compact way, such as a set of
flags in a single variable.  However, I can't think of anything that would
fit that bill, and the code is minimal anyway.

-- 
Peter Stephenson <pws@csr.com>            Software Engineer
Tel: +44 (0)1223 692070                   Cambridge Silicon Radio Limited
Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, UK


Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom