From: Simon Ruderich <simon@ruderich.org>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] _git: Don't cause errors if git isn't installed
Date: Wed, 1 Sep 2010 20:43:45 +0200 [thread overview]
Message-ID: <20100901184345.GA7553@ruderich.org> (raw)
In-Reply-To: <1281464025-24258-1-git-send-email-zsh@benizi.com>
[-- Attachment #1: Type: text/plain, Size: 1016 bytes --]
On Tue, Aug 10, 2010 at 02:13:45PM -0400, Benjamin R. Haskell wrote:
> Setting up a new system under Cygwin on Windows 7, one of the first
> things I tried (out of habit) was git<space><Tab>. I'm not sure this is
> the 'right' way to patch it, but other not-installed commands didn't
> seem to cause the same kinds of errors:
>
> $ screen <Tab># no extra output
> $ php <Tab># no extra output
> $ git <Tab>(eval):1: command not found: git
> (eval):1: command not found: git
>
> By "not the 'right' way", I just mean that this version accomplishes the goal
> of eliminating the error messages, but maybe a more-correct solution would be
> to replace some/all of the $(git...)-style calls with $(_call_program [tag]
> git...)?
>
> Best,
> Ben
Hi all,
Could somebody please review this patch.
I'm not sure myself if this is "the right way", but I think the
problem should get fixed.
Simon
--
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
prev parent reply other threads:[~2010-09-01 18:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-10 18:13 Benjamin R. Haskell
2010-09-01 18:43 ` Simon Ruderich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100901184345.GA7553@ruderich.org \
--to=simon@ruderich.org \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).