From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-28222-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 15858 invoked by alias); 1 Sep 2010 18:47:34 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 28222
Received: (qmail 27043 invoked from network); 1 Sep 2010 18:47:31 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW
	autolearn=ham version=3.3.1
Received-SPF: pass (ns1.primenet.com.au: SPF record at ruderich.org designates 78.46.69.5 as permitted sender)
Date: Wed, 1 Sep 2010 20:43:45 +0200
From: Simon Ruderich <simon@ruderich.org>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] _git: Don't cause errors if git isn't installed
Message-ID: <20100901184345.GA7553@ruderich.org>
References: <1281464025-24258-1-git-send-email-zsh@benizi.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=_zucker.schokokeks.org-12507-1283366528-0001-2"
Content-Disposition: inline
In-Reply-To: <1281464025-24258-1-git-send-email-zsh@benizi.com>
User-Agent: Mutt/1.5.20 (2010-08-30)

--=_zucker.schokokeks.org-12507-1283366528-0001-2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Aug 10, 2010 at 02:13:45PM -0400, Benjamin R. Haskell wrote:
> Setting up a new system under Cygwin on Windows 7, one of the first
> things I tried (out of habit) was git<space><Tab>.  I'm not sure this is
> the 'right' way to patch it, but other not-installed commands didn't
> seem to cause the same kinds of errors:
>
> $ screen <Tab># no extra output
> $ php <Tab># no extra output
> $ git <Tab>(eval):1: command not found: git
> (eval):1: command not found: git
>
> By "not the 'right' way", I just mean that this version accomplishes the =
goal
> of eliminating the error messages, but maybe a more-correct solution woul=
d be
> to replace some/all of the $(git...)-style calls with $(_call_program [ta=
g]
> git...)?
>
> Best,
> Ben

Hi all,

Could somebody please review this patch.

I'm not sure myself if this is "the right way", but I think the
problem should get fixed.

Simon
--=20
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9

--=_zucker.schokokeks.org-12507-1283366528-0001-2
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iQIcBAEBCAAGBQJMfp7hAAoJEJL+/bfkTDL5zPsP/3Ev8szENFI4sW7S36oIs3Zj
5ThMvqx+GrCqOk3PpcNTjyfZx4m17J2uveVFP4nRJJiAKP0nm9U/ONLNXl1L9nuo
UxnfPVi7wGSwM/C+aAxjSbvuRRwU8vS8WgoATN18t7J6Ml/MqtkOS+CywELxE2py
lhy7fdn0v9bT+Wd5jNcO6vOdD/yLgao49qGN5wVBSPX+CXs+UZ2E72cnw54UAwqL
7BeHucN6nyCncc1TNDLAt7o2QY5adlxeerRwQjRGezwYdjaZxn3OnnniybqQDUDh
kK5gBYCjFOodaY44zmk3eJC+TCf6VH9xrQzjhKcdndbw1Yw0JXlTX5m63ZTOuvfg
r4JgqwfYOiy11gibk4uw4tjV3LVT6ZE42EDF+WouBmp8yihSReBZm43jDoRv/+Zv
Us9eH1K8yv628te+pLYdvcIAsHDWHcFLn7YtQKXqijLRFDReMfpvzJZqvQnm84un
oNJmnUrM5KNJCf3dhCz62agR4Pq/lxLng+0VvIbmyUw+V/Y6TqNOo6buzz/8Neg/
1XbyIAt5YeUelctZhKWEgnaFsmqr+NVnrb7YVDlUekKIUXGGKAjblMS3LC7qsESC
3IXe8+uUPiwon2i2pjuiIq9qOGnZSjfON1Szf6vDrPZ1UVZkLbQZgyoX012q3i/2
ba/Pevv0nXZ55aMWPrtT
=FdMa
-----END PGP SIGNATURE-----

--=_zucker.schokokeks.org-12507-1283366528-0001-2--