From: Phil Pennock <zsh-workers+phil.pennock@spodhuis.org>
To: Peter Stephenson <p.w.stephenson@ntlworld.com>
Cc: zsh-workers@zsh.org
Subject: Re: Certain pattern causing shell to crash
Date: Fri, 7 Jan 2011 15:35:07 -0500 [thread overview]
Message-ID: <20110107203507.GA98237@redoubt.spodhuis.org> (raw)
In-Reply-To: <20110106195427.03ab19a9@pws-pc.ntlworld.com>
On 2011-01-06 at 19:54 +0000, Peter Stephenson wrote:
> On Thu, 6 Jan 2011 13:51:35 -0500
> Ricky Zhou <ricky@rzhou.org> wrote:
> > For what it's worth, I did a git bisect, and the segfault was introduced
> > in d234059b1c6493e5eefb6c28aa2b8a021d894d51. Hopefully this can be of
> > use to somebody more familiar with how this code works.
>
> (Ah, so I need to use
>
> git diff d234059b1c6493e5eefb6c28aa2b8a021d894d51^\!
>
> to look at it. Obvious.)
>
> Yes, that narrows it down a lot, thanks.
Oh dear, it was me fixing another problem? I'm sorry.
So in that change, I was avoiding shoving junk into the parse tree; was
that junk protecting us somehow? Did my original =~ feature manage
to introduce parallel code/decode bugs and the =~ code bug-fix exposed
the decode bug?
-Phil
next prev parent reply other threads:[~2011-01-07 20:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-06 16:08 Raghavendra D Prabhu
2011-01-06 18:22 ` Peter Stephenson
2011-01-06 18:51 ` Ricky Zhou
2011-01-06 19:54 ` Peter Stephenson
2011-01-06 20:23 ` Mikael Magnusson
2011-01-07 20:35 ` Phil Pennock [this message]
2011-01-08 20:10 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110107203507.GA98237@redoubt.spodhuis.org \
--to=zsh-workers+phil.pennock@spodhuis.org \
--cc=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).