From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-28591-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 13444 invoked by alias); 7 Jan 2011 20:51:11 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 28591
Received: (qmail 2783 invoked from network); 7 Jan 2011 20:51:09 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1
Received-SPF: none (ns1.primenet.com.au: domain at spodhuis.org does not designate permitted sender hosts)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=spodhuis.org; s=d200912;
	h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=ReFuaAzFuH50pwajMJdOojtBTmdIJYAiOs+56mGaGMU=;
	b=pgg6Zjz90YFF8TFvLoct4ELatgADI2Lvuai+co+8uYUOiRfdpGMxopyeGwKmA47ZHJZ/89gZGKc1N/vHLI6dIhjFjSG8xueYzCfJKIjo4hB9bBM6TG9anjQLUFVzz+NnL2XTg4yiVCAfUQfOpLdD0T72AaHVcUxoyRadkKtt39Q=;
Date: Fri, 7 Jan 2011 15:35:07 -0500
From: Phil Pennock <zsh-workers+phil.pennock@spodhuis.org>
To: Peter Stephenson <p.w.stephenson@ntlworld.com>
Cc: zsh-workers@zsh.org
Subject: Re: Certain pattern causing shell to crash
Message-ID: <20110107203507.GA98237@redoubt.spodhuis.org>
Mail-Followup-To: Peter Stephenson <p.w.stephenson@ntlworld.com>,
	zsh-workers@zsh.org
References: <20110106160802.GA4655@Xye>
 <20110106182201.27da4de9@pwslap01u.europe.root.pri>
 <20110106185134.GA10630@alpha.rzhou.org>
 <20110106195427.03ab19a9@pws-pc.ntlworld.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20110106195427.03ab19a9@pws-pc.ntlworld.com>

On 2011-01-06 at 19:54 +0000, Peter Stephenson wrote:
> On Thu, 6 Jan 2011 13:51:35 -0500
> Ricky Zhou <ricky@rzhou.org> wrote:
> > For what it's worth, I did a git bisect, and the segfault was introduced
> > in d234059b1c6493e5eefb6c28aa2b8a021d894d51.  Hopefully this can be of
> > use to somebody more familiar with how this code works.
> 
> (Ah, so I need to use
> 
> git diff d234059b1c6493e5eefb6c28aa2b8a021d894d51^\!
> 
> to look at it.  Obvious.)
> 
> Yes, that narrows it down a lot, thanks.

Oh dear, it was me fixing another problem?  I'm sorry.

So in that change, I was avoiding shoving junk into the parse tree; was
that junk protecting us somehow?   Did my original =~ feature manage
to introduce parallel code/decode bugs and the =~ code bug-fix exposed
the decode bug?

-Phil