From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: zsh-workers@zsh.org
Subject: Re: filename completion with umlauts (again)
Date: Sun, 9 Jan 2011 16:44:39 +0000 [thread overview]
Message-ID: <20110109164439.00543f3b@pws-pc.ntlworld.com> (raw)
In-Reply-To: <110108164814.ZM2240@torch.brasslantern.com>
On Sat, 08 Jan 2011 16:48:14 -0800
Bart Schaefer <schaefer@brasslantern.com> wrote:
> Would it even be sufficient to metafy around the match_str() entry
> point, or is the real problem that the *entire* completion system
> needs to stop treating the input line as a (char *)?
>
> In which case we almost may as well start over from scratch.
I think it is actually relatively localised, unfortunately still quite a
lot of hard-to-understand code. Most of the completion system uses
proper metafied strings and counts characters approprlately. It's only
when we get to the matching stage and inserting the result into the
command line that the boundaries blur a bit. I think apart from quite a
lot of compmatch.c, chunks of compresult.c, and a few bits elsewhere, it
doesn't actually need changing much. However, one of the problems is
deciding quite where the boundaries are. A start could probably be made
by introducing appropriate types so that we know where a char * is being
treated as an array of individual characters rather than a generic,
possibly multibyte, string --- I forget this every time I stop looking at it.
--
Peter Stephenson <p.w.stephenson@ntlworld.com>
Web page now at http://homepage.ntlworld.com/p.w.stephenson/
prev parent reply other threads:[~2011-01-09 16:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110106232712.GA11387@spiegl.de>
[not found] ` <AANLkTik9unZtuPR-4CM2oKLRT9Soct-XFWmiEajQzbK9@mail.gmail.com>
[not found] ` <20110107094419.141d8d67@pwslap01u.europe.root.pri>
[not found] ` <20110107233459.GA29168@spiegl.de>
[not found] ` <110107231048.ZM919@torch.brasslantern.com>
[not found] ` <20110108202122.5decaa0b@pws-pc.ntlworld.com>
2011-01-08 22:22 ` Bart Schaefer
2011-01-08 23:21 ` Peter Stephenson
2011-01-09 0:48 ` Bart Schaefer
2011-01-09 16:44 ` Peter Stephenson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110109164439.00543f3b@pws-pc.ntlworld.com \
--to=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).