From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: David Bitseff <bitsed@gmail.com>, zsh-workers@zsh.org
Subject: Re: PATCH: fix vi-goto-mark to allow jumps to the last mark
Date: Sun, 9 Jan 2011 21:09:56 +0000 [thread overview]
Message-ID: <20110109210956.04976fe2@pws-pc.ntlworld.com> (raw)
In-Reply-To: <201101090911.07314.bitsed@gmail.com>
On Sun, 9 Jan 2011 09:11:07 -0800
David Bitseff <bitsed@gmail.com> wrote:
> I've noticed that the vi-goto-mark zle widget doesn't work as expected on my
> system. If I try jumping to a mark that I just set using the vi-set-mark
> widget there is no movement of the cursor. To replicate the problem:
>
> 1) use vi-up-line-or-history to recall a suitably long command
> 2) use vi-forward-char a few times to move the cursor a bit
> 3) set a mark using vi-set-mark
> 4) use vi-forward-char a few times to move the cursor some more
> 5) try jumping to the mark just created using vi-goto-mark
> 6) notice no cursor movement
I'm not sure what you're doing that's different to everyone else --- it
must involve repeating the last character to go to the mark, so maybe
you've got vi-goto-mark bound to a letter --- but I've never understood
what the code you've modified is actually for, since mark 26 never gets
set. It's probably best just to remove it.
Index: Src/Zle/zle_move.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Zle/zle_move.c,v
retrieving revision 1.18
diff -p -u -r1.18 zle_move.c
--- Src/Zle/zle_move.c 5 May 2008 01:14:06 -0000 1.18
+++ Src/Zle/zle_move.c 9 Jan 2011 21:03:51 -0000
@@ -30,7 +30,7 @@
#include "zle.mdh"
#include "zle_move.pro"
-static int vimarkcs[27], vimarkline[27];
+static int vimarkcs[26], vimarkline[26];
#ifdef MULTIBYTE_SUPPORT
/*
@@ -803,16 +803,11 @@ int
vigotomark(UNUSED(char **args))
{
ZLE_INT_T ch;
- LASTFULLCHAR_T lfc = LASTFULLCHAR;
ch = getfullchar(0);
- if (ch == lfc)
- ch = 26;
- else {
- if (ch < ZWC('a') || ch > ZWC('z'))
- return 1;
- ch -= ZWC('a');
- }
+ if (ch < ZWC('a') || ch > ZWC('z'))
+ return 1;
+ ch -= ZWC('a');
if (!vimarkline[ch])
return 1;
if (curhist != vimarkline[ch] && !zle_goto_hist(vimarkline[ch], 0, 0)) {
--
Peter Stephenson <p.w.stephenson@ntlworld.com>
Web page now at http://homepage.ntlworld.com/p.w.stephenson/
next prev parent reply other threads:[~2011-01-09 21:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-09 17:11 David Bitseff
2011-01-09 21:09 ` Peter Stephenson [this message]
2011-01-09 23:58 ` Bart Schaefer
2011-01-10 9:42 ` Peter Stephenson
2011-01-10 1:44 ` David Bitseff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110109210956.04976fe2@pws-pc.ntlworld.com \
--to=p.w.stephenson@ntlworld.com \
--cc=bitsed@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).