From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] Correct isident false positive.
Date: Sun, 16 Jan 2011 19:43:42 +0000 [thread overview]
Message-ID: <20110116194342.27e60278@pws-pc.ntlworld.com> (raw)
In-Reply-To: <20110116120519.GA10298@alpha.rzhou.org>
On Sun, 16 Jan 2011 07:05:20 -0500
Ricky Zhou <ricky@rzhou.org> wrote:
> I'm not familiar with with the precise definition of an identifier, so
> somebody might want to double-check that this change (which assumes that
> valid identifiers cannot start with a '[') is correct. This fixes the
> following crash:
>
> printf %n '[0]'
Thanks, makes a lot of sense. I'll add the regression test.
Index: Test/D04parameter.ztst
===================================================================
RCS file: /cvsroot/zsh/zsh/Test/D04parameter.ztst,v
retrieving revision 1.52
diff -p -u -r1.52 D04parameter.ztst
--- Test/D04parameter.ztst 19 Dec 2010 17:42:10 -0000 1.52
+++ Test/D04parameter.ztst 16 Jan 2011 19:41:59 -0000
@@ -1401,3 +1401,7 @@
>a
>b
>c
+
+ printf "%n" '[0]'
+1:Regression test for identifier test
+?(eval):1: not an identifier: [0]
--
Peter Stephenson <p.w.stephenson@ntlworld.com>
Web page now at http://homepage.ntlworld.com/p.w.stephenson/
prev parent reply other threads:[~2011-01-16 20:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-16 12:05 Ricky Zhou
2011-01-16 19:43 ` Peter Stephenson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110116194342.27e60278@pws-pc.ntlworld.com \
--to=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).