From: Phil Pennock <zsh-workers+phil.pennock@spodhuis.org>
To: Frank Terbeck <ft@bewatermyfriend.org>
Cc: zsh-workers@zsh.org
Subject: Re: lhw@ring0.de, 611175@bugs.debian.org
Date: Fri, 11 Feb 2011 01:43:25 -0500 [thread overview]
Message-ID: <20110211064325.GA8172@redoubt.spodhuis.org> (raw)
In-Reply-To: <877hd7gjuf.fsf@ft.bewatermyfriend.org>
On 2011-02-11 at 07:34 +0100, Frank Terbeck wrote:
> ...now that CVS is back...
>
> Here's a fix for an issue with vcs_info's subversion detection, which
> was reported in the debian BTS (issue #611175¹).
That entry complains that .svn/ on its own is not sufficient and a more
thorough check is needed.
Your patch adds dead code, because if .svn already exists as a
directory, the function will have returned true already.
I suspect that you should be *replacing* the [[ -d ".svn" ]] check.
-Phil
prev parent reply other threads:[~2011-02-11 6:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-11 6:34 Frank Terbeck
2011-02-11 6:43 ` Phil Pennock [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110211064325.GA8172@redoubt.spodhuis.org \
--to=zsh-workers+phil.pennock@spodhuis.org \
--cc=ft@bewatermyfriend.org \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).