From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3424 invoked by alias); 11 Feb 2011 06:59:46 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 28740 Received: (qmail 19909 invoked from network); 11 Feb 2011 06:59:44 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received-SPF: none (ns1.primenet.com.au: domain at spodhuis.org does not designate permitted sender hosts) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=spodhuis.org; s=d200912; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=/qoSY3EAeX0IKPVK16Eio9fhZ9rzFwPONguLoIU7xAc=; b=CdjNCyg2XfnftneLx4BnZQPAOo1QcjBVDMhGC2Xfts9SAnhwUeslwbxPVB/mlhgaj2bmBgoD7liC4rGtcRxFxkpHDqP0wjRx3nhjxZ/2i4/i8ME9FMMizSDy2e/1m1ONr+NCauonXenkSXnqDP5ozR09JxX3pfcRQXrqpMMg0Eo=; Date: Fri, 11 Feb 2011 01:43:25 -0500 From: Phil Pennock To: Frank Terbeck Cc: zsh-workers@zsh.org Subject: Re: lhw@ring0.de, 611175@bugs.debian.org Message-ID: <20110211064325.GA8172@redoubt.spodhuis.org> Mail-Followup-To: Frank Terbeck , zsh-workers@zsh.org References: <877hd7gjuf.fsf@ft.bewatermyfriend.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <877hd7gjuf.fsf@ft.bewatermyfriend.org> On 2011-02-11 at 07:34 +0100, Frank Terbeck wrote: > ...now that CVS is back... > > Here's a fix for an issue with vcs_info's subversion detection, which > was reported in the debian BTS (issue #611175ยน). That entry complains that .svn/ on its own is not sufficient and a more thorough check is needed. Your patch adds dead code, because if .svn already exists as a directory, the function will have returned true already. I suspect that you should be *replacing* the [[ -d ".svn" ]] check. -Phil